public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5] dfu: nand: Verify writes
Date: Wed, 11 Feb 2015 07:45:51 +0100	[thread overview]
Message-ID: <54DAFA9F.2070108@denx.de> (raw)
In-Reply-To: <1422986296-26086-3-git-send-email-ptyser@xes-inc.com>

Hello Peter,

Am 03.02.2015 18:58, schrieb Peter Tyser:
> Previously NAND writes were not verified and could fail silently.  Add
> a verification step after all writes to NAND.
>
> Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
> ---
> I don't have a board with DFU support, so this change is untested.

Tested on the am335x based dxr2 board with writing a ubifs image
into a nand mtd partition.

Tested-by: Heiko Schocher <hs@denx.de>
Acked-by: Heiko Schocher <hs@denx.de>

bye,
Heiko

>
>   drivers/dfu/dfu_nand.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dfu/dfu_nand.c b/drivers/dfu/dfu_nand.c
> index f9ee189..a975492 100644
> --- a/drivers/dfu/dfu_nand.c
> +++ b/drivers/dfu/dfu_nand.c
> @@ -64,7 +64,7 @@ static int nand_block_op(enum dfu_op op, struct dfu_entity *dfu,
>   			return ret;
>   		/* then write */
>   		ret = nand_write_skip_bad(nand, start, &count, &actual,
> -				lim, buf, 0);
> +				lim, buf, WITH_WR_VERIFY);
>   	}
>
>   	if (ret != 0) {
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  parent reply	other threads:[~2015-02-11  6:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-03 17:58 [U-Boot] [PATCH 1/5] nand: Add verification functions Peter Tyser
2015-02-03 17:58 ` [U-Boot] [PATCH 2/5] cmd_nand: Verify writes to NAND Peter Tyser
2015-02-11  6:45   ` Heiko Schocher
2015-02-03 17:58 ` [U-Boot] [PATCH 3/5] dfu: nand: Verify writes Peter Tyser
2015-02-04  9:22   ` Lukasz Majewski
2015-02-11  6:45   ` Heiko Schocher [this message]
2015-02-03 17:58 ` [U-Boot] [PATCH 4/5] nand: Remove CONFIG_MTD_NAND_VERIFY_WRITE Peter Tyser
2015-02-11  6:46   ` Heiko Schocher
2015-02-03 17:58 ` [U-Boot] [PATCH 5/5] nand: yaffs: Remove the "nand write.yaffs" command Peter Tyser
2015-02-11  6:45 ` [U-Boot] [PATCH 1/5] nand: Add verification functions Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DAFA9F.2070108@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox