[U-Boot] [PATCH 2/2] net: phy: Add ability to program the ksz9031 skew values from the uboot env

Marek Vasut
2015-02-09T19:18:52Z

On Monday, February 09, 2015 at 03:44:33 PM, Vince Bridgers wrote:
> This patch adds the ability for the Micrel ksz9031 PHY driver to detect
> skew settings from the UBoot environment and program those values at PHY
> initialization time. This is a first step towards setting these values from
> the UBoot environment or the Micrel PHY devicetree once supported. The skew
> values may be negative or positive, therefore depends on UBoot environment
> support to read positive or negative values in units of picoseconds.
>
> Signed-off-by: Vince Bridgers <vbridger@opensource.altera.com>

Hi!

We already do this kind of a programming in board/altera/socfpga/socfpga.c
in board_phy_config(), don't we ?

Also, see [1], once I apply this, the DT support (not DM) for SoCFPGA will
become mandatory. Won't it make more sense to pull these values from the
DT instead of poluting the board environment with those please ?

Thanks!

[1] http://git.denx.de/?p=u-boot/u-boot-
socfpga.git;a=shortlog;h=refs/heads/topic/vip-arriav

Best regards,
Marek Vasut