public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jeroen Hofstee <jeroen@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sandbox: Adjust the order of the NO_SDL check
Date: Fri, 13 Feb 2015 00:12:12 +0100	[thread overview]
Message-ID: <54DD334C.8070906@myspectrum.nl> (raw)
In-Reply-To: <1423619555-629-1-git-send-email-sjg@chromium.org>

Hello Simon,

On 11-02-15 02:52, Simon Glass wrote:
> An option is provided to avoid using SDL in U-Boot sandbox (and drop
> support for the LCD). However the check in the Makefile is too late
> and warnings are printed even if NO_SDL=y is given.
>
> Adjust the order to avoid this warning.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>   arch/sandbox/config.mk | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/sandbox/config.mk b/arch/sandbox/config.mk
> index e38a44b..7b84f02 100644
> --- a/arch/sandbox/config.mk
> +++ b/arch/sandbox/config.mk
> @@ -5,10 +5,16 @@ PLATFORM_CPPFLAGS += -D__SANDBOX__ -U_FORTIFY_SOURCE
>   PLATFORM_CPPFLAGS += -DCONFIG_ARCH_MAP_SYSMEM -DCONFIG_SYS_GENERIC_BOARD
>   PLATFORM_LIBS += -lrt
>   
> +# Define this to avoid linking with SDL, which requires SDL libraries
> +# This can solve 'sdl-config: Command not found' errors
> +ifneq ($(NO_SDL),)
> +PLATFORM_CPPFLAGS += -DSANDBOX_NO_SDL
> +else
>   ifdef CONFIG_SANDBOX_SDL
>   PLATFORM_LIBS += $(shell sdl-config --libs)
>   PLATFORM_CPPFLAGS += $(shell sdl-config --cflags)
>   endif
> +endif
>   
>   # Support generic board on sandbox
>   __HAVE_ARCH_GENERIC_BOARD := y
> @@ -18,9 +24,3 @@ cmd_u-boot__ = $(CC) -o $@ -T u-boot.lds \
>   	$(PLATFORM_LIBS) -Wl,-Map -Wl,u-boot.map
>   
>   CONFIG_ARCH_DEVICE_TREE := sandbox
> -
> -# Define this to avoid linking with SDL, which requires SDL libraries
> -# This can solve 'sdl-config: Command not found' errors
> -ifneq ($(NO_SDL),)
> -PLATFORM_CPPFLAGS += -DSANDBOX_NO_SDL
> -endif

yup, feel free to commit this (it can't do any harm just prevents some
warnings). Which I guess translates to

Acked-by: Jeroen Hofstee <jeroen@myspectrum.nl>

Regards,
Jeroen

  reply	other threads:[~2015-02-12 23:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-11  1:52 [U-Boot] [PATCH] sandbox: Adjust the order of the NO_SDL check Simon Glass
2015-02-12 23:12 ` Jeroen Hofstee [this message]
2015-02-15 21:40   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DD334C.8070906@myspectrum.nl \
    --to=jeroen@myspectrum.nl \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox