public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] MPC8541 / MPC8555E: DDR_SDRAM_CLK_CNLT[SS_EN] handling
Date: Fri, 13 Feb 2015 09:21:26 -0600	[thread overview]
Message-ID: <54DE1676.6080009@freescale.com> (raw)
In-Reply-To: <20150213053512.GL4740@cumulusnetworks.com>

You are right. We used to have this bit set for 8555 and 8541. I believe it was
removed/dropped/lost by this commit 457caecdbca3df21a93abff19eab12dbc61b7897.

York


On 02/12/2015 11:35 PM, Curt Brune wrote:
> Hello,
> 
> I am curious about the setting of the SS_EN bit in the
> DDR_SDRAM_CLK_CNLT register:
> 
>    Source synchronous enable. This bit field must be set during
>    initialization. See Section 9.6.1, ?DDR SDRAM Initialization
>    Sequence,? for details.
> 
>    0 - Reserved
>    1 - The address and command are sent to the DDR SDRAMs source
>        synchronously.
> 
> The MPC8555E reference manual and this app note are pretty clear that
> this bit should be set:
> 
>   http://cache.freescale.com/files/32bit/doc/app_note/AN2805.pdf (page 17)
> 
> set_ddr_sdram_clk_cntl() in u-boot/drivers/ddr/fsl/ctrl_regs.c has this:
> 
>         clk_adjust = popts->clk_adjust;
>         ddr->ddr_sdram_clk_cntl = (clk_adjust & 0xF) << 23;
> 
> There is no accounting for the SS_EN bit on 8541/8555E.  I would have
> expected to see an #ifdef for the MPC8555 that sets the SS_EN bit.
> 
> I know 8541 has been around forever and is working fine.  I am just
> trying to find some back ground information on this setting.
> 
> Searching the old mailing lists did not turn up anything useful.
> 
> Any insight is appreciated.
> 
> Cheers,
> Curt
> 

      reply	other threads:[~2015-02-13 15:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-13  5:35 [U-Boot] MPC8541 / MPC8555E: DDR_SDRAM_CLK_CNLT[SS_EN] handling Curt Brune
2015-02-13 15:21 ` York Sun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DE1676.6080009@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox