[U-Boot] [PATCH] tools: imagetool: Remove "INSERT BEFORE" from linker script

["Andreas Bießmann" <andreas.devel@googlemail.com>]

On 16.02.15 17:55, Tom Rini wrote:
> On Mon, Feb 16, 2015 at 03:05:45PM +0100, Lukasz Majewski wrote:
> 
>> Not all linkers are able to parse "INSERT BEFORE" part of the linker script.
>> For example following (rather new) "gold" one:
>>
>> GNU gold (GNU Binutils for Debian 2.22) 1.11
>>
>> produces following error:
>>   HOSTLD  tools/mkenvimage
>> /usr/bin/ld: error: ./tools/imagetool.lds:23:8: syntax error, unexpected STRING
>> /usr/bin/ld: fatal error: unable to parse script file ./tools/imagetool.lds
>> collect2: error: ld returned 1 exit status
>> make[1]: *** [tools/mkenvimage] Error 1
>> make: *** [tools] Error 2
>>
>> The problem has already been reported, but no evident solution has been
>> proposed:
>> https://bugzilla.redhat.com/show_bug.cgi?id=927573#c5
>>
>> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> 
> Guilherme, can you please confirm that things still work as expected for
> you with this patch applied?  Thanks!

I vote for 437762 [1] as replacement for this patch.

It is not only the linker script which is not understood by the Darwin
linker. The linker generated lists work just differently on Darwin,
therefore a93648d197df48fa46dd55f925ff70468bd81c71 broke mkimage for me.
Guilherme told the RFC would work [2].

Best regards

Andreas Bie?mann

[1] http://patchwork.ozlabs.org/patch/437762/
[2] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/211224