public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Troy Kisky <troy.kisky@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] mmc: fsl_esdhc: Add support to force VSELECT set
Date: Mon, 16 Feb 2015 18:38:31 -0700	[thread overview]
Message-ID: <54E29B97.3000003@boundarydevices.com> (raw)
In-Reply-To: <1424122683-29357-2-git-send-email-otavio@ossystems.com.br>

On 2/16/2015 2:38 PM, Otavio Salvador wrote:
> Some boards cannot do voltage negotiation but need to set the VSELECT
> bit forcely to ensure it to work at 1.8V.
> 
> This commit adds CONFIG_SYS_FSL_ESDHC_FORCE_VSELECT flag for this use.
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> 
>  doc/README.fsl-esdhc    | 1 +
>  drivers/mmc/fsl_esdhc.c | 4 ++++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/doc/README.fsl-esdhc b/doc/README.fsl-esdhc
> index b70f271..619c6b2 100644
> --- a/doc/README.fsl-esdhc
> +++ b/doc/README.fsl-esdhc
> @@ -1,5 +1,6 @@
>  CONFIG_SYS_FSL_ESDHC_LE means ESDHC IP is in little-endian mode.
>  CONFIG_SYS_FSL_ESDHC_BE means ESDHC IP is in big-endian mode.
> +CONFIG_SYS_FSL_ESDHC_FORCE_VSELECT forces to run at 1.8V.
>  
>  Accessing ESDHC registers can be determined by ESDHC IP's endian
>  mode or processor's endian mode.
> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
> index eb0fbf9..5fde2b6 100644
> --- a/drivers/mmc/fsl_esdhc.c
> +++ b/drivers/mmc/fsl_esdhc.c
> @@ -524,6 +524,10 @@ static int esdhc_init(struct mmc *mmc)
>  	/* Set timout to the maximum value */
>  	esdhc_clrsetbits32(&regs->sysctl, SYSCTL_TIMEOUT_MASK, 14 << 16);
>  
> +#ifdef CONFIG_SYS_FSL_ESDHC_FORCE_VSELECT
> +	esdhc_setbits32(&regs->vendorspec, ESDHC_VENDORSPEC_VSELECT);
> +#endif
> +
>  	return 0;
>  }
>  
> 

What if 1 controller needs it set and another needs it clear?

  reply	other threads:[~2015-02-17  1:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-16 21:38 [U-Boot] [PATCH 1/4] mmc: fsl_esdhc: Add CMD11 support to switch to 1.8V Otavio Salvador
2015-02-16 21:38 ` [U-Boot] [PATCH 2/4] mmc: fsl_esdhc: Add support to force VSELECT set Otavio Salvador
2015-02-17  1:38   ` Troy Kisky [this message]
2015-02-17  7:10     ` Marek Vasut
2015-02-17 12:36     ` Otavio Salvador
2015-02-17 17:18       ` Troy Kisky
2015-02-17 19:43         ` Marek Vasut
2015-02-17 20:16           ` Otavio Salvador
2015-02-16 21:38 ` [U-Boot] [PATCH 3/4] imx: mx6sl: Extend USDHC SD2 pins to support 8-wire use Otavio Salvador
2015-02-16 21:38 ` [U-Boot] [PATCH 4/4] warp: Add initial WaRP Board support Otavio Salvador
2015-02-17  7:13   ` Marek Vasut
2015-02-17  9:45   ` Stefano Babic
2015-02-17  7:11 ` [U-Boot] [PATCH 1/4] mmc: fsl_esdhc: Add CMD11 support to switch to 1.8V Marek Vasut
2015-02-17 12:40   ` Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E29B97.3000003@boundarydevices.com \
    --to=troy.kisky@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox