From mboxrd@z Thu Jan 1 00:00:00 1970 From: Troy Kisky Date: Tue, 17 Feb 2015 10:18:31 -0700 Subject: [U-Boot] [PATCH 2/4] mmc: fsl_esdhc: Add support to force VSELECT set In-Reply-To: References: <1424122683-29357-1-git-send-email-otavio@ossystems.com.br> <1424122683-29357-2-git-send-email-otavio@ossystems.com.br> <54E29B97.3000003@boundarydevices.com> Message-ID: <54E377E7.1010009@boundarydevices.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 2/17/2015 5:36 AM, Otavio Salvador wrote: > On Mon, Feb 16, 2015 at 11:38 PM, Troy Kisky > wrote: >> On 2/16/2015 2:38 PM, Otavio Salvador wrote: >>> Some boards cannot do voltage negotiation but need to set the VSELECT >>> bit forcely to ensure it to work at 1.8V. >>> >>> This commit adds CONFIG_SYS_FSL_ESDHC_FORCE_VSELECT flag for this use. >>> >>> Signed-off-by: Otavio Salvador > ... >> >> What if 1 controller needs it set and another needs it clear? > > I am not sure it makes much sense to have one in 3V3 and another 1V8. Does it? > I guess if the need ever arises it can be changed then. It just seems better to pass this as a flag for the controller now.