From mboxrd@z Thu Jan 1 00:00:00 1970 From: Przemyslaw Marczak Date: Wed, 18 Feb 2015 18:50:03 +0100 Subject: [U-Boot] [PATCH] gpt: fix error reporting on partition table write failures In-Reply-To: <1422286995-23681-1-git-send-email-robh@kernel.org> References: <1422286995-23681-1-git-send-email-robh@kernel.org> Message-ID: <54E4D0CB.2030202@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Rob, On 01/26/2015 04:43 PM, Rob Herring wrote: > The gpt command always reports success even if writing the partition table > failed. Propagate the return value of gpt_restore so we get proper status > reported. > > Signed-off-by: Rob Herring > --- > common/cmd_gpt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/common/cmd_gpt.c b/common/cmd_gpt.c > index e38422d..75df3fe 100644 > --- a/common/cmd_gpt.c > +++ b/common/cmd_gpt.c > @@ -281,11 +281,11 @@ static int gpt_default(block_dev_desc_t *blk_dev_desc, const char *str_part) > } > > /* save partitions layout to disk */ > - gpt_restore(blk_dev_desc, str_disk_guid, partitions, part_count); > + ret = gpt_restore(blk_dev_desc, str_disk_guid, partitions, part_count); > free(str_disk_guid); > free(partitions); > > - return 0; > + return ret; > } > > /** > This one commit, is ok. Reviewed-by: Przemyslaw Marczak Best regards, -- Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak at samsung.com