From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Thu, 19 Feb 2015 08:41:47 +0100 Subject: [U-Boot] [PATCH 01/22] dm: i2c: Add a missing memory allocaton check In-Reply-To: <1424293849-22193-2-git-send-email-sjg@chromium.org> References: <1424293849-22193-1-git-send-email-sjg@chromium.org> <1424293849-22193-2-git-send-email-sjg@chromium.org> Message-ID: <54E593BB.20106@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Simon, Am 18.02.2015 22:10, schrieb Simon Glass: > This strdup() is missing a check. Add it. > > Signed-off-by: Simon Glass > --- > > drivers/i2c/i2c-uclass.c | 2 ++ > 1 file changed, 2 insertions(+) Good catch, Thanks! Acked-by: Heiko Schocher bye, Heiko > > diff --git a/drivers/i2c/i2c-uclass.c b/drivers/i2c/i2c-uclass.c > index a6991bf..b890806 100644 > --- a/drivers/i2c/i2c-uclass.c > +++ b/drivers/i2c/i2c-uclass.c > @@ -230,6 +230,8 @@ static int i2c_bind_driver(struct udevice *bus, uint chip_addr, uint offset_len, > > snprintf(name, sizeof(name), "generic_%x", chip_addr); > str = strdup(name); > + if (!str) > + return -ENOMEM; > ret = device_bind_driver(bus, "i2c_generic_chip_drv", str, &dev); > debug("%s: device_bind_driver: ret=%d\n", __func__, ret); > if (ret) > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany