From mboxrd@z Thu Jan 1 00:00:00 1970 From: Przemyslaw Marczak Date: Fri, 20 Feb 2015 10:46:24 +0100 Subject: [U-Boot] [PATCH v2 6/8] kconfig: malloc: add option for skip memset at malloc init In-Reply-To: <20150220163238.DDBC.AA925319@jp.panasonic.com> References: <54E4882D.4010300@samsung.com> <20150220163238.DDBC.AA925319@jp.panasonic.com> Message-ID: <54E70270.5020501@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello, On 02/20/2015 08:32 AM, Masahiro Yamada wrote: > > On Thu, 19 Feb 2015 11:59:07 -0700 > Simon Glass wrote: > >> +Masahiro >> >> Hi, >> >> On 18 February 2015 at 05:40, Przemyslaw Marczak wrote: >>> Hi Simon, >>> >>> On 02/18/2015 05:32 AM, Simon Glass wrote: >>>> >>>> Hi Przemyslaw, >>>> >>>> On 16 February 2015 at 08:13, Przemyslaw Marczak >>>> wrote: >>>>> >>>>> Signed-off-by: Przemyslaw Marczak >>>>> --- >>>>> Kconfig | 26 +++++++++++++++++++------- >>>>> 1 file changed, 19 insertions(+), 7 deletions(-) >>>>> >>>>> diff --git a/Kconfig b/Kconfig >>>>> index 4157da3..e08e44a 100644 >>>>> --- a/Kconfig >>>>> +++ b/Kconfig >>>>> @@ -57,13 +57,25 @@ config CC_OPTIMIZE_FOR_SIZE >>>>> This option is enabled by default for U-Boot. >>>> >>>> >>>> Ah, you have done this. Then I think you can merge this patch with the >>>> dlmalloc patch and drop the README one. >>>> >>> >>> Shouldn't we keep both, README and Kconfig help? >>> Kconfig is just a configuration tool, README is a documentation. >>> Sometimes it could be faster to find something in the text instead of >>> config. >> >> Agreed, but isn't it going to be a pain to add it in both places and >> keep it in sync? Maybe we could create a script which creates a >> README.kconfig containing all the options and help. >> > > I agree with Simon. > > README is useful when we need a wider and more general explanation about a feature, > for ex. doc/driver-model/README.txt > > Per-config explanation should be documented in Kconfig only. > > Another reasone I prefer Kconfig help is: > When we remove a CONFIG from Kconfig, the documentation in a separete README > might be left over. > Yes, but this is the maintainer role, to keep it in sync. It's no problem for me. I can remove the README entry. I just think that it may be useful for people who just starting the fun with U-Boot. > > BTW, I did not know that U-Boot filled all the malloc space with zero. The same as I, but checking the execution time of some functions, shows that something takes too long time. > > I guess our consensus is that malloc() returns uninitialized memory. Yes, as should it do. > > So, I am happy with this patch. (Perhaps, could it be enabled by default? ) > This could potentially break something. Let's give a free hand to maintainers to enable this after test. And this is why I add such config option. > > > Best Regards > Masahiro Yamada > > So as Simon and Masahiro wish, I will remove the README entry for this. Best regards, -- Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak at samsung.com