public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/2] mc34704: Add the definition of ONOFFA bit
@ 2015-02-21 19:20 Fabio Estevam
  2015-02-21 19:20 ` [U-Boot] [PATCH 2/2] mx25pdk: Turn on the LCD supply Fabio Estevam
  0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2015-02-21 19:20 UTC (permalink / raw)
  To: u-boot

ONOFFA is the bit 3 of the GENERAL2 register.

Add its definition.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 include/mc34704.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/mc34704.h b/include/mc34704.h
index 53716e0..482d51a 100644
--- a/include/mc34704.h
+++ b/include/mc34704.h
@@ -40,6 +40,7 @@ enum {
 /* GENERAL2 register fields */
 #define ONOFFE		(1 << 0)
 #define ONOFFD		(1 << 1)
+#define ONOFFA		(1 << 3)
 #define ALLOFF		(1 << 4)
 
 #endif /* __MC34704_H__ */
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH 2/2] mx25pdk: Turn on the LCD supply
  2015-02-21 19:20 [U-Boot] [PATCH 1/2] mc34704: Add the definition of ONOFFA bit Fabio Estevam
@ 2015-02-21 19:20 ` Fabio Estevam
  2015-02-23  8:03   ` Stefano Babic
  0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2015-02-21 19:20 UTC (permalink / raw)
  To: u-boot

From: Fabio Estevam <fabio.estevam@freescale.com>

Currently there is no support for MC34704 PMIC in the mainline kernel.

Turn on the LCD supply via bootloader for the time being, so that we could 
use the LCD in the kernel.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/freescale/mx25pdk/mx25pdk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/freescale/mx25pdk/mx25pdk.c b/board/freescale/mx25pdk/mx25pdk.c
index 71a395c..01dac72 100644
--- a/board/freescale/mx25pdk/mx25pdk.c
+++ b/board/freescale/mx25pdk/mx25pdk.c
@@ -146,8 +146,8 @@ int board_late_init(void)
 	if (!p)
 		return -ENODEV;
 
-	/* Turn on Ethernet PHY supply */
-	pmic_reg_write(p, MC34704_GENERAL2_REG, ONOFFE);
+	/* Turn on Ethernet PHY and LCD supplies */
+	pmic_reg_write(p, MC34704_GENERAL2_REG, ONOFFE | ONOFFA);
 
 	return 0;
 }
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH 2/2] mx25pdk: Turn on the LCD supply
  2015-02-21 19:20 ` [U-Boot] [PATCH 2/2] mx25pdk: Turn on the LCD supply Fabio Estevam
@ 2015-02-23  8:03   ` Stefano Babic
  0 siblings, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2015-02-23  8:03 UTC (permalink / raw)
  To: u-boot

On 21/02/2015 20:20, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Currently there is no support for MC34704 PMIC in the mainline kernel.
> 
> Turn on the LCD supply via bootloader for the time being, so that we could 
> use the LCD in the kernel.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  board/freescale/mx25pdk/mx25pdk.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/board/freescale/mx25pdk/mx25pdk.c b/board/freescale/mx25pdk/mx25pdk.c
> index 71a395c..01dac72 100644
> --- a/board/freescale/mx25pdk/mx25pdk.c
> +++ b/board/freescale/mx25pdk/mx25pdk.c
> @@ -146,8 +146,8 @@ int board_late_init(void)
>  	if (!p)
>  		return -ENODEV;
>  
> -	/* Turn on Ethernet PHY supply */
> -	pmic_reg_write(p, MC34704_GENERAL2_REG, ONOFFE);
> +	/* Turn on Ethernet PHY and LCD supplies */
> +	pmic_reg_write(p, MC34704_GENERAL2_REG, ONOFFE | ONOFFA);
>  
>  	return 0;
>  }
> 

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-02-23  8:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-21 19:20 [U-Boot] [PATCH 1/2] mc34704: Add the definition of ONOFFA bit Fabio Estevam
2015-02-21 19:20 ` [U-Boot] [PATCH 2/2] mx25pdk: Turn on the LCD supply Fabio Estevam
2015-02-23  8:03   ` Stefano Babic

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox