From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dinh Nguyen <dinguyen@opensource.altera.com>
Date: Mon, 23 Feb 2015 10:37:20 -0600
Subject: [U-Boot] [PATCHv1 01/22] arm: socfpga: spl: Add main sdram code
In-Reply-To: <20150215232543.GA26950@amd>
References: <1421253662-27222-1-git-send-email-dinguyen@opensource.altera.com>
 <1421253662-27222-2-git-send-email-dinguyen@opensource.altera.com>
 <20150215232543.GA26950@amd>
Message-ID: <54EB5740.10005@opensource.altera.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de



On 2/15/15 5:25 PM, Pavel Machek wrote:
> Hi!
> 
>> +#if ENABLE_BRINGUP_DEBUGGING
> 
> Could we get rid of this for initial merge?

Yeah, it can be removed.

> 
>> +static inline void reg_file_set_sub_stage(uint32_t set_sub_stage)
>> +{
>> +	/* Read the current group and stage */
>> +	uint32_t cur_stage_group = IORD_32DIRECT(REG_FILE_CUR_STAGE, 0);
> 
> Could normal u-boot memory access macros be used here?
> 
I'll look..

Dinh