From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] sunxi: mmc: Always declare High Capacity capability
Date: Tue, 24 Feb 2015 12:39:33 +0100 [thread overview]
Message-ID: <54EC62F5.9010703@redhat.com> (raw)
In-Reply-To: <54EC3E13.8030905@redhat.com>
Hi,
On 24-02-15 10:02, Hans de Goede wrote:
> Hi,
>
> On 23-02-15 18:45, Pantelis Antoniou wrote:
>> Hi Hans,
>>
>>> On Feb 19, 2015, at 22:03 , Hans de Goede <hdegoede@redhat.com> wrote:
>>>
>>> High Capacity (e)MMC cards work fine on sun4i / sun5i, and not having this
>>> capability set causes u-boot to not recognize the eMMC on an Utoo P66 A13
>>> tablet, so always set it thereby fixing this.
>>>
>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>> ---
>>> drivers/mmc/sunxi_mmc.c | 6 +-----
>>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c
>>> index ebfec7c..2233545 100644
>>> --- a/drivers/mmc/sunxi_mmc.c
>>> +++ b/drivers/mmc/sunxi_mmc.c
>>> @@ -449,11 +449,7 @@ struct mmc *sunxi_mmc_init(int sdc_no)
>>>
>>> cfg->voltages = MMC_VDD_32_33 | MMC_VDD_33_34;
>>> cfg->host_caps = MMC_MODE_4BIT;
>>> - cfg->host_caps |= MMC_MODE_HS_52MHz | MMC_MODE_HS;
>>> -#if defined(CONFIG_MACH_SUN6I) || defined(CONFIG_MACH_SUN7I) || \
>>> - defined(CONFIG_MACH_SUN8I) || defined(CONFIG_MACH_SUN9I)
>>> - cfg->host_caps |= MMC_MODE_HC;
>>> -#endif
>>> + cfg->host_caps |= MMC_MODE_HS_52MHz | MMC_MODE_HS | MMC_MODE_HC;
>>> cfg->b_max = CONFIG_SYS_MMC_MAX_BLK_COUNT;
>>>
>>> cfg->f_min = 400000;
>>> --
>>> 2.1.0
>>
>> Thanks, applied.
>
> Thanks, but since this was touching only sunxi code this has already been
> merged through the sunxi tree, if you rebase on the latest master this
> should drop from your tree.
Ah I see that Tom has already pulled from your tree too, so now the patch
is upstream through both pulls, which git handles without problems, so
we're good here.
Regards,
Hans
prev parent reply other threads:[~2015-02-24 11:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 20:03 [U-Boot] [PATCH 1/2] sunxi: mmc: Always declare High Capacity capability Hans de Goede
2015-02-19 20:03 ` [U-Boot] [PATCH 2/2] sunxi: Add support for the UTOO P66 tablet Hans de Goede
2015-02-21 10:32 ` Ian Campbell
2015-02-21 10:32 ` [U-Boot] [PATCH 1/2] sunxi: mmc: Always declare High Capacity capability Ian Campbell
2015-02-23 17:45 ` Pantelis Antoniou
2015-02-24 9:02 ` Hans de Goede
2015-02-24 11:39 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EC62F5.9010703@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox