public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Agner <stefan.agner@toradex.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] apalis/colibri_t30: fix MMC/SD card detect GPIOs
Date: Tue, 24 Feb 2015 19:15:09 +0100	[thread overview]
Message-ID: <54ECBFAD.7080808@toradex.com> (raw)
In-Reply-To: <991ff2b06acf6f1ebd5d62022a36460e0b5b5477.1424182672.git.marcel@ziswiler.com>


On 17.02.2015 15:28, Marcel Ziswiler wrote:
> This fixes the MMC/SD card detect GPIOs for Apalis T30 which got broken
> by the following commit:
>
> 2b2b50bc8748bf1ddb2d96da7157f9eecbe24961
>
> While at it also re-add the comments describing which particular
> Apalis/Colibri pins those GPIOs are on.

Acked-by: Stefan Agner <stefan.agner@toradex.com>

>
> Signed-off-by: Marcel Ziswiler <marcel@ziswiler.com>
> ---
>  arch/arm/dts/tegra30-apalis.dts  | 9 +++++++--
>  arch/arm/dts/tegra30-colibri.dts | 4 +++-
>  2 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/dts/tegra30-apalis.dts b/arch/arm/dts/tegra30-apalis.dts
> index 75c5d5f..13ab42b 100644
> --- a/arch/arm/dts/tegra30-apalis.dts
> +++ b/arch/arm/dts/tegra30-apalis.dts
> @@ -247,13 +247,15 @@
>  	sdhci at 78000000 {
>  		status = "okay";
>  		bus-width = <4>;
> -		cd-gpios = <&gpio TEGRA_GPIO(CC, 5) GPIO_ACTIVE_HIGH>;
> +		/* SD1_CD# */
> +		cd-gpios = <&gpio TEGRA_GPIO(CC, 5) GPIO_ACTIVE_LOW>;
>  	};
>  
>  	sdhci at 78000400 {
>  		status = "okay";
>  		bus-width = <8>;
> -		cd-gpios = <&gpio TEGRA_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
> +		/* MMC1_CD# */
> +		cd-gpios = <&gpio TEGRA_GPIO(V, 3) GPIO_ACTIVE_LOW>;
>  	};
>  
>  	sdhci at 78000600 {
> @@ -266,12 +268,14 @@
>  	usb at 7d000000 {
>  		status = "okay";
>  		dr_mode = "peripheral";
> +		/* USBO1_EN */
>  		nvidia,vbus-gpio = <&gpio TEGRA_GPIO(T, 5) GPIO_ACTIVE_HIGH>;
>  	};
>  
>  	/* EHCI instance 1: USB2_DP/N -> USBH2_DP/N */
>  	usb at 7d004000 {
>  		status = "okay";
> +		/* USBH_EN */
>  		nvidia,vbus-gpio = <&gpio TEGRA_GPIO(DD, 1) GPIO_ACTIVE_HIGH>;
>  		phy_type = "utmi";
>  	};
> @@ -279,6 +283,7 @@
>  	/* EHCI instance 2: USB3_DP/N -> USBH3_DP/N */
>  	usb at 7d008000 {
>  		status = "okay";
> +		/* USBH_EN */
>  		nvidia,vbus-gpio = <&gpio TEGRA_GPIO(DD, 1) GPIO_ACTIVE_HIGH>;
>  	};
>  
> diff --git a/arch/arm/dts/tegra30-colibri.dts b/arch/arm/dts/tegra30-colibri.dts
> index 6cd1902..36533dc 100644
> --- a/arch/arm/dts/tegra30-colibri.dts
> +++ b/arch/arm/dts/tegra30-colibri.dts
> @@ -64,7 +64,7 @@
>  	sdhci at 78000200 {
>  		status = "okay";
>  		bus-width = <4>;
> -		cd-gpios = <&gpio TEGRA_GPIO(C, 7) GPIO_ACTIVE_LOW>;
> +		cd-gpios = <&gpio TEGRA_GPIO(C, 7) GPIO_ACTIVE_LOW>; /* MMCD */
>  	};
>  
>  	sdhci at 78000600 {
> @@ -83,12 +83,14 @@
>  	usb at 7d004000 {
>  		status = "okay";
>  		phy_type = "utmi";
> +		/* VBUS_LAN */
>  		nvidia,vbus-gpio = <&gpio TEGRA_GPIO(DD, 2) GPIO_ACTIVE_HIGH>;
>  	};
>  
>  	/* EHCI instance 2: USB3_DP/N -> USBH_P/N */
>  	usb at 7d008000 {
>  		status = "okay";
> +		/* USBH_PEN */
>  		nvidia,vbus-gpio = <&gpio TEGRA_GPIO(W, 2) GPIO_ACTIVE_LOW>;
>  	};
>  };

  parent reply	other threads:[~2015-02-24 18:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-17 14:28 [U-Boot] [PATCH 0/4] various fixes for apalis/colibri_t30 Marcel Ziswiler
2015-02-17 14:28 ` [U-Boot] [PATCH 1/4] dm: tegra: dts: add aliases for spi on apalis_t30 Marcel Ziswiler
2015-02-17 20:31   ` Stephen Warren
2015-02-17 14:28 ` [U-Boot] [PATCH 2/4] apalis/colibri_t30: fix MMC/SD card detect GPIOs Marcel Ziswiler
2015-02-18  5:01   ` Simon Glass
2015-02-24 18:15   ` Stefan Agner [this message]
2015-02-17 14:28 ` [U-Boot] [PATCH 3/4] apalis_t30: enable gigabit ethernet via pcie Marcel Ziswiler
2015-02-18  5:01   ` Simon Glass
2015-02-17 14:28 ` [U-Boot] [PATCH 4/4] apalis/colibri_t30: add misc cmds increase buf sizes and max args Marcel Ziswiler
2015-02-17 20:38   ` Stephen Warren
2015-03-01  0:19     ` Marcel Ziswiler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54ECBFAD.7080808@toradex.com \
    --to=stefan.agner@toradex.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox