[U-Boot] [PATCH v2] tegra20: tamonten: Fix the early gpio init

[U-Boot] [PATCH v2] tegra20: tamonten: Fix the early gpio init

[Alban Bedel]

As the GPIO driver isn't ready when gpio_early_init() is called the
normal GPIO API can't be used. Fix this like on seaboard by using the
lower level function tegra_spl_gpio_direction_output().

Signed-off-by: Alban Bedel <alban.bedel@avionic-design.de>
---
v2: Updated the log message to better describe the problem
---
 board/avionic-design/common/tamonten.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/board/avionic-design/common/tamonten.c b/board/avionic-design/common/tamonten.c
index 9c86779..ea2425a 100644
--- a/board/avionic-design/common/tamonten.c
+++ b/board/avionic-design/common/tamonten.c
@@ -23,8 +23,10 @@
 #ifdef CONFIG_BOARD_EARLY_INIT_F
 void gpio_early_init(void)
 {
+#ifndef CONFIG_SPL_BUILD
 	gpio_request(GPIO_PI4, NULL);
-	gpio_direction_output(GPIO_PI4, 1);
+#endif
+	tegra_spl_gpio_direction_output(GPIO_PI4, 1);
 }
 #endif
 
-- 
2.3.0

[U-Boot] [PATCH v2] tegra20: tamonten: Fix the early gpio init

[Simon Glass]

+Tom Rini

Hi,

On 24 February 2015 at 10:50, Alban Bedel <alban.bedel@avionic-design.de> wrote:
> As the GPIO driver isn't ready when gpio_early_init() is called the
> normal GPIO API can't be used. Fix this like on seaboard by using the
> lower level function tegra_spl_gpio_direction_output().
>
> Signed-off-by: Alban Bedel <alban.bedel@avionic-design.de>
> ---
> v2: Updated the log message to better describe the problem
> ---
>  board/avionic-design/common/tamonten.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/board/avionic-design/common/tamonten.c b/board/avionic-design/common/tamonten.c
> index 9c86779..ea2425a 100644
> --- a/board/avionic-design/common/tamonten.c
> +++ b/board/avionic-design/common/tamonten.c
> @@ -23,8 +23,10 @@
>  #ifdef CONFIG_BOARD_EARLY_INIT_F
>  void gpio_early_init(void)
>  {
> +#ifndef CONFIG_SPL_BUILD
>         gpio_request(GPIO_PI4, NULL);
> -       gpio_direction_output(GPIO_PI4, 1);
> +#endif
> +       tegra_spl_gpio_direction_output(GPIO_PI4, 1);
>  }
>  #endif
>
> --
> 2.3.0
>

From here:

http://lists.denx.de/pipermail/u-boot/2014-October/190492.html

Believe it or not we have still not pulled in the SPL series, but you
can test with it (u-boot-dm/spl-working).

I am waiting for Masahiro's kconfig change to go in and then I think I
can go ahead.

Regards,
Simon

[U-Boot] [PATCH v2] tegra20: tamonten: Fix the early gpio init

[Stephen Warren]

On 02/24/2015 10:50 AM, Alban Bedel wrote:
> As the GPIO driver isn't ready when gpio_early_init() is called the
> normal GPIO API can't be used. Fix this like on seaboard by using the
> lower level function tegra_spl_gpio_direction_output().

Acked-by: Stephen Warren <swarren@nvidia.com>

This seems to match what Seaboard does, so it seems like a fine fix for now.