From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 06/20] tegra: spi: Drop the claim_bus() method to correct delays
Date: Wed, 25 Feb 2015 16:14:05 -0700 [thread overview]
Message-ID: <54EE573D.30701@wwwdotorg.org> (raw)
In-Reply-To: <1424212195-7501-7-git-send-email-sjg@chromium.org>
On 02/17/2015 03:29 PM, Simon Glass wrote:
> At present the driver does not properly honour the requested SPI CS
> deactivation delay since the SPI bus is changed in the claim_bus() method.
>
> Everything the claim_bus() method does can be done when the device is probed
> (setting the speed and mode) and at the start of a new transfer (where the
> fifo_status is already cleared). So drop this method.
>
> Also, until the delay is complete, we should not touch the bus, so make sure
> that spi_cs_activate() is called before other things are done in the xfer()
> method.
> diff --git a/drivers/spi/tegra114_spi.c b/drivers/spi/tegra114_spi.c
> - setbits_le32(®s->command1, SPI_CMD1_M_S | SPI_CMD1_CS_SW_HW |
> - (priv->mode << SPI_CMD1_MODE_SHIFT));
...
> + setbits_le32(&priv->regs->command1, SPI_CMD1_M_S | SPI_CMD1_CS_SW_HW |
> + (priv->mode << SPI_CMD1_MODE_SHIFT) | SPI_CMD1_CS_SW_VAL);
Is that addition of SPI_CMD1_CS_SW_VAL there relative to the old code
intended?
next prev parent reply other threads:[~2015-02-25 23:14 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 22:29 [U-Boot] [PATCH 0/20] tegra: Expand Nyan-big support Simon Glass
2015-02-17 22:29 ` [U-Boot] [PATCH 01/20] dm: spi: Avoid setting the speed with every transfer Simon Glass
2015-05-02 20:58 ` Simon Glass
2015-02-17 22:29 ` [U-Boot] [PATCH 02/20] cros_ec: Show the protocol version in the debug message Simon Glass
2015-05-02 20:58 ` Simon Glass
2015-02-17 22:29 ` [U-Boot] [PATCH 03/20] cros_ec: Handle the single duplex requirement in cros_ec Simon Glass
2015-05-02 20:58 ` Simon Glass
2015-02-17 22:29 ` [U-Boot] [PATCH 04/20] tegra: Provide more accurate microsecond time Simon Glass
2015-02-25 23:10 ` Stephen Warren
2015-03-29 13:00 ` Simon Glass
2015-02-17 22:29 ` [U-Boot] [PATCH 05/20] tegra: cros_ec: Add tegra support for Chrome OS EC Simon Glass
2015-02-17 22:29 ` [U-Boot] [PATCH 06/20] tegra: spi: Drop the claim_bus() method to correct delays Simon Glass
2015-02-25 23:14 ` Stephen Warren [this message]
2015-03-29 13:10 ` Simon Glass
2015-02-17 22:29 ` [U-Boot] [PATCH 07/20] dm: tegra: cros_ec: Enable Chrome OS EC on Nyan-big Simon Glass
2015-02-25 23:15 ` Stephen Warren
2015-03-29 13:00 ` Simon Glass
2015-02-17 22:29 ` [U-Boot] [PATCH 08/20] dm: gpio: Add an implementation for gpio_get_number() Simon Glass
2015-02-17 22:29 ` [U-Boot] [PATCH 09/20] tegra: spi: Support slow SPI rates Simon Glass
2015-02-17 22:29 ` [U-Boot] [PATCH 10/20] tegra: clock: Support enabling external clocks Simon Glass
2015-02-17 22:29 ` [U-Boot] [PATCH 11/20] tegra: clock: Adjust PLL access to avoid a warning Simon Glass
2015-02-17 22:29 ` [U-Boot] [PATCH 12/20] tegra: Introduce SRAM repair on tegra124 Simon Glass
2015-02-17 22:29 ` [U-Boot] [PATCH 13/20] tegra: Add missing tegra124 peripherals Simon Glass
2015-02-17 22:29 ` [U-Boot] [PATCH 14/20] tegra: Increase maximum arguments to 32 Simon Glass
2015-02-17 22:29 ` [U-Boot] [PATCH 15/20] tegra: lcd: Tidy up clock init Simon Glass
2015-02-17 22:29 ` [U-Boot] [PATCH 16/20] tegra: Allow board-specific init Simon Glass
2015-02-17 22:29 ` [U-Boot] [PATCH 17/20] tegra: nyan-big: Add additional clock and kernel init Simon Glass
2015-02-25 23:23 ` Stephen Warren
2015-03-29 13:02 ` Simon Glass
2015-02-17 22:29 ` [U-Boot] [PATCH 18/20] Add Chrome OS config header Simon Glass
2015-02-25 23:28 ` Stephen Warren
2015-02-26 9:15 ` thomas.langer at lantiq.com
2015-05-13 13:19 ` Simon Glass
2015-05-15 15:27 ` Stephen Warren
2015-05-18 21:40 ` Simon Glass
2015-02-17 22:29 ` [U-Boot] [PATCH 19/20] tegra: config: Allow Chrome OS environment settings to be included Simon Glass
2015-02-17 22:29 ` [U-Boot] [PATCH 20/20] tegra: config: nyan-big: Add options required by Chrome OS boot Simon Glass
2015-02-25 23:31 ` Stephen Warren
2015-05-13 13:56 ` Simon Glass
2015-05-15 15:34 ` Stephen Warren
2015-05-18 21:33 ` Simon Glass
2015-05-19 15:41 ` Stephen Warren
2015-05-19 18:01 ` Simon Glass
2015-05-19 21:36 ` Stephen Warren
2015-05-19 23:27 ` Simon Glass
2015-05-20 1:44 ` Stephen Warren
2015-05-20 3:00 ` Simon Glass
2015-05-20 10:21 ` Peter Robinson
2015-05-20 13:40 ` Simon Glass
2015-05-20 14:04 ` Stephen Warren
2015-05-20 14:14 ` Simon Glass
2015-02-26 0:12 ` [U-Boot] [PATCH 0/20] tegra: Expand Nyan-big support Sjoerd Simons
2015-02-28 5:11 ` Simon Glass
2015-03-30 8:14 ` Sjoerd Simons
2015-03-30 23:51 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EE573D.30701@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox