[U-Boot] [PATCH 1/2] mx31: Fix boot hang by avoiding vector relocation

[U-Boot] [PATCH 1/2] mx31: Fix boot hang by avoiding vector relocation

[Fabio Estevam]

Since commit 3ff46cc42b9d73d0 ("arm: relocate the exception vectors") mx31
does not boot anymore.

Add a specific relocate_vectors macro that skips the vector relocation, as the
i.MX31 SoC does not provide RAM at the high vectors address (0xFFFF0000), and
(0x00000000) maps to ROM.

This allows mx31 to boot again.

Cc: Anatolij Gustschin <agust@denx.de>
Cc: Magnus Lilja <lilja.magnus@gmail.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Anatolij/Maguns,

I don't have access to a mx31 board.

Could you please test this patch?

Thanks

 arch/arm/cpu/arm1136/mx31/Makefile   |  4 ++++
 arch/arm/cpu/arm1136/mx31/relocate.S | 23 +++++++++++++++++++++++
 2 files changed, 27 insertions(+)
 create mode 100644 arch/arm/cpu/arm1136/mx31/relocate.S

diff --git a/arch/arm/cpu/arm1136/mx31/Makefile b/arch/arm/cpu/arm1136/mx31/Makefile
index 9670ed9..dcbd570 100644
--- a/arch/arm/cpu/arm1136/mx31/Makefile
+++ b/arch/arm/cpu/arm1136/mx31/Makefile
@@ -8,3 +8,7 @@
 obj-y	+= generic.o
 obj-y	+= timer.o
 obj-y	+= devices.o
+
+ifndef CONFIG_SPL_BUILD
+obj-y  += relocate.o
+endif
diff --git a/arch/arm/cpu/arm1136/mx31/relocate.S b/arch/arm/cpu/arm1136/mx31/relocate.S
new file mode 100644
index 0000000..1c556df
--- /dev/null
+++ b/arch/arm/cpu/arm1136/mx31/relocate.S
@@ -0,0 +1,23 @@
+/*
+ *  relocate - i.MX31-specific vector relocation
+ *
+ *  Copyright (c) 2013  Albert ARIBAUD <albert.u.boot@aribaud.net>
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#include <linux/linkage.h>
+
+/*
+ * The i.MX31 SoC is very specific with respect to exceptions: it
+ * does not provide RAM at the high vectors address (0xFFFF0000),
+ * thus only the low address (0x00000000) is useable; but that is
+ * in ROM, so let's avoid relocating the vectors.
+ */
+	.section	.text.relocate_vectors,"ax",%progbits
+
+ENTRY(relocate_vectors)
+
+	bx	lr
+
+ENDPROC(relocate_vectors)
-- 
1.9.1

[U-Boot] [PATCH 2/2] mx35: Fix boot hang by avoiding vector relocation

[Fabio Estevam]

Since commit 3ff46cc42b9d73d0 ("arm: relocate the exception vectors") mx35
does not boot anymore.

Add a specific relocate_vectors macro that skips the vector relocation, as the
i.MX35 SoC does not provide RAM at the high vectors address (0xFFFF0000), and
(0x00000000) maps to ROM.

This allows mx35 to boot again.

Cc: Sebastian Priebe <sebastian.priebe@cadcon.de>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Sebastian,

I don't have access to a mx35 board.

Could you please test this patch?

Thanks

 arch/arm/cpu/arm1136/mx35/Makefile   |  4 ++++
 arch/arm/cpu/arm1136/mx35/relocate.S | 23 +++++++++++++++++++++++
 2 files changed, 27 insertions(+)
 create mode 100644 arch/arm/cpu/arm1136/mx35/relocate.S

diff --git a/arch/arm/cpu/arm1136/mx35/Makefile b/arch/arm/cpu/arm1136/mx35/Makefile
index c533215..796db9c 100644
--- a/arch/arm/cpu/arm1136/mx35/Makefile
+++ b/arch/arm/cpu/arm1136/mx35/Makefile
@@ -10,3 +10,7 @@
 obj-y	+= generic.o
 obj-y	+= timer.o
 obj-y	+= mx35_sdram.o
+
+ifndef CONFIG_SPL_BUILD
+obj-y  += relocate.o
+endif
diff --git a/arch/arm/cpu/arm1136/mx35/relocate.S b/arch/arm/cpu/arm1136/mx35/relocate.S
new file mode 100644
index 0000000..43003f8
--- /dev/null
+++ b/arch/arm/cpu/arm1136/mx35/relocate.S
@@ -0,0 +1,23 @@
+/*
+ *  relocate - i.MX35-specific vector relocation
+ *
+ *  Copyright (c) 2013  Albert ARIBAUD <albert.u.boot@aribaud.net>
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#include <linux/linkage.h>
+
+/*
+ * The i.MX35 SoC is very specific with respect to exceptions: it
+ * does not provide RAM at the high vectors address (0xFFFF0000),
+ * thus only the low address (0x00000000) is useable; but that is
+ * in ROM, so let's avoid relocating the vectors.
+ */
+	.section	.text.relocate_vectors,"ax",%progbits
+
+ENTRY(relocate_vectors)
+
+	bx	lr
+
+ENDPROC(relocate_vectors)
-- 
1.9.1

[U-Boot] [PATCH 2/2] mx35: Fix boot hang by avoiding vector relocation

[Stefano Babic]

Hi Fabio,

On 23/02/2015 13:09, Fabio Estevam wrote:
> Since commit 3ff46cc42b9d73d0 ("arm: relocate the exception vectors") mx35
> does not boot anymore.
> 
> Add a specific relocate_vectors macro that skips the vector relocation, as the
> i.MX35 SoC does not provide RAM at the high vectors address (0xFFFF0000), and
> (0x00000000) maps to ROM.
> 
> This allows mx35 to boot again.
> 
> Cc: Sebastian Priebe <sebastian.priebe@cadcon.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Sebastian,
> 
> I don't have access to a mx35 board.
> 
> Could you please test this patch?
> 
> Thanks
> 

Thanks for the patch !

I have found again a mx35pdk and I could test your patch. 2015.04-rc1
is running on that.

Tested-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[U-Boot] [PATCH 1/2] mx31: Fix boot hang by avoiding vector relocation

[Anatolij Gustschin]

Hi Fabio,

On Mon, 23 Feb 2015 09:09:08 -0300
Fabio Estevam <fabio.estevam@freescale.com> wrote:

> Since commit 3ff46cc42b9d73d0 ("arm: relocate the exception vectors") mx31
> does not boot anymore.
> 
> Add a specific relocate_vectors macro that skips the vector relocation, as the
> i.MX31 SoC does not provide RAM at the high vectors address (0xFFFF0000), and
> (0x00000000) maps to ROM.
> 
> This allows mx31 to boot again.
> 
> Cc: Anatolij Gustschin <agust@denx.de>
> Cc: Magnus Lilja <lilja.magnus@gmail.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Anatolij/Maguns,
> 
> I don't have access to a mx31 board.
> 
> Could you please test this patch?

Thanks for the patch! I'll get access to the imx31_phycore board at the
beginning of the next week and will test it. Unfortunately I can't test
it earlier.

Thanks,

Anatolij

[U-Boot] [PATCH 1/2] mx31: Fix boot hang by avoiding vector relocation

[Magnus Lilja]

Hi

On 23 February 2015 at 14:03, Anatolij Gustschin <agust@denx.de> wrote:
> Hi Fabio,
>
> On Mon, 23 Feb 2015 09:09:08 -0300
> Fabio Estevam <fabio.estevam@freescale.com> wrote:
>
>> Since commit 3ff46cc42b9d73d0 ("arm: relocate the exception vectors") mx31
>> does not boot anymore.
>>
>> Add a specific relocate_vectors macro that skips the vector relocation, as the
>> i.MX31 SoC does not provide RAM at the high vectors address (0xFFFF0000), and
>> (0x00000000) maps to ROM.
>>
>> This allows mx31 to boot again.
>>
>> Cc: Anatolij Gustschin <agust@denx.de>
>> Cc: Magnus Lilja <lilja.magnus@gmail.com>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>> Anatolij/Maguns,
>>
>> I don't have access to a mx31 board.
>>
>> Could you please test this patch?
>
> Thanks for the patch! I'll get access to the imx31_phycore board at the
> beginning of the next week and will test it. Unfortunately I can't test
> it earlier.

I might get around to test it before that but I can't promise that.

Regards, Magnus

[U-Boot] [PATCH 1/2] mx31: Fix boot hang by avoiding vector relocation

[Stefano Babic]

Hi Fabio, Magnus, Anatolji, Sebastian,

On 23/02/2015 13:09, Fabio Estevam wrote:
> Since commit 3ff46cc42b9d73d0 ("arm: relocate the exception vectors") mx31
> does not boot anymore.
> 
> Add a specific relocate_vectors macro that skips the vector relocation, as the
> i.MX31 SoC does not provide RAM at the high vectors address (0xFFFF0000), and
> (0x00000000) maps to ROM.
> 
> This allows mx31 to boot again.
> 
> Cc: Anatolij Gustschin <agust@denx.de>
> Cc: Magnus Lilja <lilja.magnus@gmail.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

As boards are currently broken, I think can help if patches are merged
even if they are not fully tested. I could at least test on a mx35, and
board boots again.

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================