public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] DWC2 driver issues
Date: Mon, 2 Mar 2015 19:34:59 +0530	[thread overview]
Message-ID: <54F46E0B.8050309@ti.com> (raw)
In-Reply-To: <201503021238.53699.marex@denx.de>



On Monday 02 March 2015 05:08 PM, Marek Vasut wrote:
> On Friday, February 20, 2015 at 04:22:58 AM, Stephen Warren wrote:
>
> Hi!
>
> [...]
>
>>>> Existing code that invokes USB transfers will call (a) once. (a) will
>>>> call (b) as many times as needed to break up the packet into small
>>>> chunks. (b) will either send the transaction to the HW (HS devices or
>>>> directly attached LS/FS devices), or perform the split transaction
>>>> handling (remotely attached LS/FS devices).
>>>>
>>>> Does that sound like a reasonable approach?
>>>>
>>>> I can start looking into getting split transactions going; I just
>>>> couldn't motivate myself last Friday night.
>>>
>>> Do you plan to do this on the USB stack level or USB controller driver
>>> level please ?
>>
>> I expect I'd put at least the split transaction stuff into the USB
>> controller driver. While I'm not that familiar with anything other than
>> standard EHCI, I'd guess the need to manually manage split transaction
>> was unique to DWC2?
>
> Looks that way. +CC Kishon , what about DWC3 ?

SPLIT transaction is specific to host controller and the DWC3 work I did is
gadget driver. So I'd assume it should be handled by xhci driver.
>
>> The split of transfers into max-packet-sized transfers could plausibly
>> be useful in the core, but again my guess is that the need to do this is
>> DWC2-specific?
>
> Kishon ?

AFAIK dwc3 requires max-packet "aligned" request sizes and we manage it by
using bounce buffer and chained TRBs. The hw itself takes care of sending
max-packet-sized transfers. But again I'm talking w.r.t gadget driver.

Cheers
Kishon

  reply	other threads:[~2015-03-02 14:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-16 18:28 [U-Boot] DWC2 driver issues Stephen Warren
2015-02-19 14:29 ` Marek Vasut
2015-02-19 22:21   ` Dinh Nguyen
2015-02-20  3:22   ` Stephen Warren
2015-03-02 11:38     ` Marek Vasut
2015-03-02 14:04       ` Kishon Vijay Abraham I [this message]
2015-02-28  4:33   ` Stephen Warren
2015-03-02 11:42     ` Marek Vasut
2015-03-02 23:33       ` Stephen Warren
2015-03-05 20:59         ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F46E0B.8050309@ti.com \
    --to=kishon@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox