From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: imx: Fix conflicting definition types of 'get_reset_cause'
Date: Mon, 02 Mar 2015 19:32:23 +0100 [thread overview]
Message-ID: <54F4ACB7.1090107@denx.de> (raw)
In-Reply-To: <201503021927.46813.marex@denx.de>
Hi Marek, Otavio,
On 02/03/2015 19:27, Marek Vasut wrote:
> On Monday, March 02, 2015 at 07:10:58 PM, Otavio Salvador wrote:
>> The common i.MX definition of 'get_reset_cause' function is non-static
>> so the overriden ones should follow it. This fixes following error:
>>
>> ,----
>>
>> | arch/arm/imx-common/cpu.c:29:14: error: static declaration
>> |
>> | of 'get_reset_cause' follows non-static declaration
>> | static char *get_reset_cause(void)
>>
>> `----
>>
>> The fix has been done in all i.MX based SoCs plus vf610.
>>
>> Fixes [YOCTO: #7384].
>>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>
> You should instead drop the prototype from sys_proto.h and repair
> the only one non-static occurance in arch/arm/imx-common/cpu.c .
>
This is the fix I sent this morning:
http://patchwork.ozlabs.org/patch/445002/
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2015-03-02 18:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 18:10 [U-Boot] [PATCH] arm: imx: Fix conflicting definition types of 'get_reset_cause' Otavio Salvador
2015-03-02 18:27 ` Marek Vasut
2015-03-02 18:32 ` Stefano Babic [this message]
2015-03-02 18:35 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F4ACB7.1090107@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox