[U-Boot] [PATCH] mpc837xerdb: "fix Calling __hwconfig without a buffer" warning

[U-Boot] [PATCH] mpc837xerdb: "fix Calling __hwconfig without a buffer" warning

[Sinan Akman]

Signed-off-by: Sinan Akman <sinan@writeme.com>
---
 board/freescale/mpc837xerdb/mpc837xerdb.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/board/freescale/mpc837xerdb/mpc837xerdb.c b/board/freescale/mpc837xerdb/mpc837xerdb.c
index e0a1031..565f815 100644
--- a/board/freescale/mpc837xerdb/mpc837xerdb.c
+++ b/board/freescale/mpc837xerdb/mpc837xerdb.c
@@ -166,8 +166,13 @@ int board_early_init_f(void)
 int board_mmc_init(bd_t *bd)
 {
 	struct immap __iomem *im = (struct immap __iomem *)CONFIG_SYS_IMMR;
+	char buffer[HWCONFIG_BUFFER_SIZE] = {0};
+	int esdhc_hwconfig_enabled = 0;
 
-	if (!hwconfig("esdhc"))
+	if (getenv_f("hwconfig", buffer, sizeof(buffer)) > 0)
+		esdhc_hwconfig_enabled = hwconfig_f("esdhc", buffer);
+
+	if (esdhc_hwconfig_enabled == 0)
 		return 0;
 
 	clrsetbits_be32(&im->sysconf.sicrl, SICRL_USB_B, SICRL_USB_B_SD);
-- 
1.7.6.5

[U-Boot] [PATCH] mpc837xerdb: "fix Calling __hwconfig without a buffer" warning

[Sinan Akman]

Tom Rini wrote:
> On 02/03/2015 02:31 PM, Sinan Akman wrote:
>>   Hi Tom
>>
>>   As per our discussion with Kim at IRC, could you please
>> pick this for rc2 :
>>
>> http://u-boot.10912.n7.nabble.com/PATCH-mpc837xerdb-fix-Calling-hwconfig-without-a-buffer-warning-tp202599.html
> 
> OK, I've assigned to myself in patchwork and I'll pick it up soon.  Thanks!

   Perfect. Thanks much.

   I'll now cc you all mpx83xx patches and if we don't
hear from Kim for some time or any other comment I'll
remind you to apply. Kim seems to be fine with this
process.

   BTW, sorry I forgot to cc to the list initially
so adding it now as well.

   Thanks much again

   Sinan Akman

[U-Boot] [PATCH] mpc837xerdb: "fix Calling __hwconfig without a buffer" warning

[Sinan Akman]

   Hi Tom

On 02/03/2015 03:24 PM, Sinan Akman wrote:
> Tom Rini wrote:
>> On 02/03/2015 02:31 PM, Sinan Akman wrote:
>>>   Hi Tom
>>>
>>>   As per our discussion with Kim at IRC, could you please
>>> pick this for rc2 :
>>>
>>> http://u-boot.10912.n7.nabble.com/PATCH-mpc837xerdb-fix-Calling-hwconfig-without-a-buffer-warning-tp202599.html
>>>
>>
>> OK, I've assigned to myself in patchwork and I'll pick it up soon.
>> Thanks!


   Could you please pick up the patch above as we
agreed earlier. It fixes a warning and it didn't
find its way to -rc2.

   I cc'ed both of your new addresses.

   Thanks much

   Sinan Akman

>
>    Perfect. Thanks much.
>
>    I'll now cc you all mpx83xx patches and if we don't
> hear from Kim for some time or any other comment I'll
> remind you to apply. Kim seems to be fine with this
> process.
>