From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 03 Mar 2015 17:47:38 +0100 Subject: [U-Boot] [PATCH] spl_mem_init.c : Added support for mDDR in SPL for i.MX28 In-Reply-To: <1424702099-7799-1-git-send-email-m.cavallini@koansoftware.com> References: <1424702099-7799-1-git-send-email-m.cavallini@koansoftware.com> Message-ID: <54F5E5AA.5060407@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marco, On 23/02/2015 15:34, Marco Cavallini wrote: > > Signed-off-by: Marco Cavallini > --- > arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c > index a744e5d..9e11288 100644 > --- a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c > +++ b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c > @@ -315,9 +315,27 @@ static void mx28_mem_init(void) > > debug("SPL: Initialising mx28 SDRAM Controller\n"); > > +#ifndef CONFIG_SYS_MXS_mDDR > /* Set DDR2 mode */ > writel(PINCTRL_EMI_DS_CTRL_DDR_MODE_DDR2, > &pinctrl_regs->hw_pinctrl_emi_ds_ctrl_set); > +#else > + /* Set mDDR mode */ > + writel( PINCTRL_EMI_DS_CTRL_ADDRESS_MA_MASK | > + PINCTRL_EMI_DS_CTRL_CONTROL_MA_MASK | > + PINCTRL_EMI_DS_CTRL_DUALPAD_MA_MASK | > + PINCTRL_EMI_DS_CTRL_SLICE3_MA_MASK | > + PINCTRL_EMI_DS_CTRL_SLICE2_MA_MASK | > + PINCTRL_EMI_DS_CTRL_SLICE1_MA_MASK | > + PINCTRL_EMI_DS_CTRL_SLICE0_MA_MASK, > + &pinctrl_regs->hw_pinctrl_emi_ds_ctrl); > + > + /* Configure Pins 0-15 as EMI pins */ > + writel(0, &pinctrl_regs->hw_pinctrl_muxsel10); > + writel(0, &pinctrl_regs->hw_pinctrl_muxsel11); > + writel(0, &pinctrl_regs->hw_pinctrl_muxsel12); > + writel(0, &pinctrl_regs->hw_pinctrl_muxsel13); > +#endif The thing is that there is no use case in mainline, because no board is using it. To avoid that the issue is completely hidden, I suggest to add at least documentation for CONFIG_SYS_MXS_mDDR in README. If someone else will use mDDR, it will be easy to find how. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================