public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 4/4] ARM: DRA7: fastboot: Implement reboot-bootloader command
Date: Tue, 3 Mar 2015 11:46:47 -0600	[thread overview]
Message-ID: <54F5F387.8060409@ti.com> (raw)
In-Reply-To: <CAL6W153WjuZv5rge6gws-qVKDjXx8YO0eqFqQ0PgyhW6vbq+1w@mail.gmail.com>

On 03/03/2015 11:31 AM, Dileep Katta wrote:
> On 3 March 2015 at 19:45, Rob Herring <robherring2@gmail.com> wrote:
> 
>> On Tue, Mar 3, 2015 at 5:10 AM, Dileep Katta <dileep.katta@linaro.org>
>> wrote:

[...]
>>> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
>>> index 48199bf..00791be 100644
>>> --- a/common/cmd_bootm.c
>>> +++ b/common/cmd_bootm.c
>>> @@ -729,6 +729,11 @@ int do_booti(cmd_tbl_t *cmdtp, int flag, int argc,
>> char * const argv[])
>>>  {
>>>         int ret;
>>>
>>> +#if defined(CONFIG_CMD_FASTBOOT)
>>> +       if (!fb_check_reboot_flag())
>>> +               do_fastboot(cmdtp, flag, argc, argv);
>>> +#endif
>>
>> Part of the booti command? First, booti is for arm64 Image files. How
>> does this work for you?
> 
> This was ported from an existing DRA7 implementation as per latest u-boot.

Ummm... I am curious and wonder why the authorship changed if it was
just a "port"? Might be nice to point to original source where this
was picked up from
http://git.omapzoom.org/?p=repo/u-boot.git;a=shortlog;h=refs/heads/p-ti-u-boot-2014.07

For example patch #2
http://git.omapzoom.org/?p=repo/u-boot.git;a=commit;h=5df0356d4c34611d32f905dea51e9c908075eec1
I cant see much of a change here to have an authorship change perhaps?

Do I understand that Angela is ok with the same? please confirm.

> Should have sent it
> as RFC patch, as this is not verified due to unavailability of board.

Hmm... interesting.... maybe Vish can help here?

[...]

-- 
Regards,
Nishanth Menon

      reply	other threads:[~2015-03-03 17:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 17:31 [U-Boot] [PATCH v1 4/4] ARM: DRA7: fastboot: Implement reboot-bootloader command Dileep Katta
2015-03-03 17:46 ` Nishanth Menon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F5F387.8060409@ti.com \
    --to=nm@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox