From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] ARMv8 targets are broken on 2015.04-rc3
Date: Thu, 5 Mar 2015 15:27:59 -0800 [thread overview]
Message-ID: <54F8E67F.9030107@freescale.com> (raw)
In-Reply-To: <20150305232618.GZ25373@bill-the-cat>
On 03/05/2015 03:26 PM, Tom Rini wrote:
> On Thu, Mar 05, 2015 at 11:11:16AM -0800, York Sun wrote:
>> Guys,
>>
>> I found these targets are broken on tag 2015.04-rc3
>>
>> ls2085a_emu_D4
>> vexpress_aemv8a
>> vexpress_aemv8a_juno
>> ls2085a_emu
>> vexpress_aemv8a_semi
>> xilinx_zynqmp
>> ls2085a_simu
>>
>> git bisect points to this commit a389531439a7d5cea2829054edcf438dc76e79a9.
>> However it is really caused by this one
>>
>> commit e771a3d538a4fbe235864061ff3c81a8acb11082
>> Author: Marc Zyngier <marc.zyngier@arm.com>
>> AuthorDate: Sat Jul 12 14:24:07 2014 +0100
>> Commit: Albert ARIBAUD <albert.u.boot@aribaud.net>
>> CommitDate: Mon Jul 28 17:19:52 2014 +0200
>>
>> ARM: HYP/non-sec/PSCI: emit DT nodes
>>
>> Generate the PSCI node in the device tree.
>>
>> Also add a reserve section for the "secure" code that lives in
>> in normal RAM, so that the kernel knows it'd better not trip on
>> it.
>>
>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>> Acked-by: Ian Campbell <ijc@hellion.org.uk>
>>
>> This commit add armv7.h to bootm-fdt.c file.
>>
>> --- a/arch/arm/lib/bootm-fdt.c
>> +++ b/arch/arm/lib/bootm-fdt.c
>> @@ -17,13 +17,14 @@
>>
>> #include <common.h>
>> #include <fdt_support.h>
>> +#include <asm/armv7.h>
>>
>> Shouldn't this line be architecture dependent?
>
> Looking at the whole commit, how is this breaking things?
>
Shall this include armv7.h regardless which architecture is compiled? This
didn't cause any problem until a recent commit a389531 changes armv7.h.
York
next prev parent reply other threads:[~2015-03-05 23:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 19:11 [U-Boot] ARMv8 targets are broken on 2015.04-rc3 York Sun
2015-03-05 23:26 ` Tom Rini
2015-03-05 23:27 ` York Sun [this message]
2015-03-05 23:33 ` Tom Rini
2015-03-05 23:45 ` York Sun
2015-03-06 0:59 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F8E67F.9030107@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox