From: Nishanth Menon <nm@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V5 05/11] ARM: OMAP: Change set_pl310_ctrl_reg to be generic
Date: Fri, 6 Mar 2015 11:38:20 -0600 [thread overview]
Message-ID: <54F9E60C.8090002@ti.com> (raw)
In-Reply-To: <20150306170807.GC17895@bill-the-cat>
On 03/06/2015 11:08 AM, Tom Rini wrote:
> On Thu, Mar 05, 2015 at 10:41:00PM -0600, Nishanth Menon wrote:
>
>> set_pl310_ctrl_reg does use the Secure Monitor Call (SMC) to setup
>> PL310 control register, however, that is something that is generic
>> enough to be used for OMAP5 generation of processors as well. The only
>> difference being the service being invoked for the function.
>>
>> So, convert the service to a macro and use a generic name (same as
>> that used in Linux for some consistency). While at that, also add a
>> data barrier which is necessary as per recommendation.
>>
>> While at this, smc #0 is maintained as handcoded assembly thanks to
>> various gcc version eccentricities, discussion thread:
>> http://marc.info/?t=142542166800001&r=1&w=2
>>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
> [snip]
>> diff --git a/arch/arm/cpu/armv7/omap-common/lowlevel_init.S b/arch/arm/cpu/armv7/omap-common/lowlevel_init.S
>> index e19c7aececdd..80619b04df5d 100644
>> --- a/arch/arm/cpu/armv7/omap-common/lowlevel_init.S
>> +++ b/arch/arm/cpu/armv7/omap-common/lowlevel_init.S
>> @@ -22,11 +22,15 @@ ENTRY(save_boot_params)
>> b save_boot_params_ret
>> ENDPROC(save_boot_params)
>>
>> -ENTRY(set_pl310_ctrl_reg)
>> - PUSH {r4-r11, lr} @ save registers - ROM code may pollute
>> +ENTRY(omap_smc1)
> [snip]
>> diff --git a/arch/arm/include/asm/arch-omap4/sys_proto.h b/arch/arm/include/asm/arch-omap4/sys_proto.h
>> index e19975efaf50..f425e3af54f5 100644
>> --- a/arch/arm/include/asm/arch-omap4/sys_proto.h
>> +++ b/arch/arm/include/asm/arch-omap4/sys_proto.h
>> @@ -37,7 +37,7 @@ void do_set_mux(u32 base, struct pad_conf_entry const *array, int size);
>> void set_muxconf_regs_essential(void);
>> u32 wait_on_value(u32, u32, void *, u32);
>> void sdelay(unsigned long);
>> -void set_pl310_ctrl_reg(u32 val);
>> +void omap_smc1(u32 service, u32 val);
>
> I kinda feel we should be putting the prototype into omap_common.h as
> that's as close as we've got today for a header that matches up to the
> code in arch/arm/cpu/armv7/omap-common/, thanks!
>
OK. will try to get it done. Thanks for the suggestion on this.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2015-03-06 17:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 4:40 [U-Boot] [PATCH V5 00/11] ARM: OMAP3-DRA7: CP15 erratum workarounds and improvements Nishanth Menon
2015-03-06 4:40 ` [U-Boot] [PATCH V5 01/11] ARM: Introduce erratum workaround for 798870 Nishanth Menon
2015-03-06 4:40 ` [U-Boot] [PATCH V5 02/11] ARM: Introduce erratum workaround for 454179 Nishanth Menon
2015-03-06 4:40 ` [U-Boot] [PATCH V5 03/11] ARM: Introduce erratum workaround for 430973 Nishanth Menon
2015-03-06 4:40 ` [U-Boot] [PATCH V5 04/11] ARM: Introduce erratum workaround for 621766 Nishanth Menon
2015-03-06 4:41 ` [U-Boot] [PATCH V5 05/11] ARM: OMAP: Change set_pl310_ctrl_reg to be generic Nishanth Menon
2015-03-06 17:08 ` Tom Rini
2015-03-06 17:38 ` Nishanth Menon [this message]
2015-03-06 4:41 ` [U-Boot] [PATCH V5 06/11] ARM: OMAP3: Rename omap3.h to omap.h to be generic as all SoCs Nishanth Menon
2015-03-06 4:41 ` [U-Boot] [PATCH V5 07/11] ARM: OMAP3: Get rid of omap3_gp_romcode_call and replace with omap_smc1 Nishanth Menon
2015-03-06 4:41 ` [U-Boot] [PATCH V5 08/11] ARM: DRA7 / OMAP5: Add workaround for ARM errata 798870 Nishanth Menon
2015-03-06 4:41 ` [U-Boot] [PATCH V5 09/11] ARM: OMAP5 / DRA7: Setup L2 Aux Control Register with recommended configuration Nishanth Menon
[not found] ` <20150306170553.GB17895@bill-the-cat>
2015-03-06 17:33 ` Nishanth Menon
2015-03-06 4:41 ` [U-Boot] [PATCH V5 10/11] ARM: OMAP3: Enable workaround for ARM errata 454179, 430973, 621766 Nishanth Menon
2015-03-06 4:41 ` [U-Boot] [PATCH V5 11/11] ARM: OMAP3: rx51: " Nishanth Menon
2015-03-06 17:39 ` [U-Boot] [PATCH V5 00/11] ARM: OMAP3-DRA7: CP15 erratum workarounds and improvements Nishanth Menon
2015-03-06 21:28 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F9E60C.8090002@ti.com \
--to=nm@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox