public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] common/board_f.c: Enable IMX watchdog in init_func_watchdog_init()
Date: Tue, 10 Mar 2015 07:17:51 +0100	[thread overview]
Message-ID: <54FE8C8F.7020100@denx.de> (raw)
In-Reply-To: <1425916182-12023-1-git-send-email-sr@denx.de>

Hello Stefan,

Am 09.03.2015 16:49, schrieb Stefan Roese:
> Without this patch, the IMX watchdog will not be initialized. And therefor
> not active. This patch fixes this by calling hw_watchdog_init() also when
> CONFIG_IMX_WATCHDOG is defined.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
>   common/board_f.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

Thanks, Good catch!

> diff --git a/common/board_f.c b/common/board_f.c
> index 4d8b8a6..1dfaa2a 100644
> --- a/common/board_f.c
> +++ b/common/board_f.c
> @@ -111,7 +111,8 @@ static int init_func_watchdog_init(void)
>   {
>   # if defined(CONFIG_HW_WATCHDOG) && (defined(CONFIG_BLACKFIN) || \
>   	defined(CONFIG_M68K) || defined(CONFIG_MICROBLAZE) || \
> -	defined(CONFIG_SH) || defined(CONFIG_AT91SAM9_WATCHDOG))
> +	defined(CONFIG_SH) || defined(CONFIG_AT91SAM9_WATCHDOG)) || \
> +	defined(CONFIG_IMX_WATCHDOG)

Hmm.. are you sure, you set the brackets correct? I think it should be:

-	defined(CONFIG_SH) || defined(CONFIG_AT91SAM9_WATCHDOG))
+	defined(CONFIG_SH) || defined(CONFIG_AT91SAM9_WATCHDOG) || \
                                                                ^
+	defined(CONFIG_IMX_WATCHDOG))
                                     ^
so it only gets enabled if CONFIG_HW_WATCHDOG is defined ... or is this
not necessary for imx6?

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2015-03-10  6:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09 15:49 [U-Boot] [PATCH] common/board_f.c: Enable IMX watchdog in init_func_watchdog_init() Stefan Roese
2015-03-10  6:17 ` Heiko Schocher [this message]
2015-03-10  6:59   ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54FE8C8F.7020100@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox