From: Peng Fan <Peng.Fan@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: fsl_esdhc fix register offset
Date: Wed, 11 Mar 2015 08:58:37 +0800 [thread overview]
Message-ID: <54FF933D.7050906@freescale.com> (raw)
In-Reply-To: <201503101445.40531.marex@denx.de>
Hi, Marek
On 3/10/2015 9:45 PM, Marek Vasut wrote:
> On Tuesday, March 10, 2015 at 08:35:46 AM, Peng Fan wrote:
>> Commit f022d36e8a4517b2a9d25ff2d75bd2459d0c68b1 introduces
>> error register offset.
>>
>> Change the "char reserved3[59]" to "char reserved3[56]".
>>
>> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> This should probably be applied to 2015.04 .
>
> What are the symptoms of this bug please ?
I just found the reserved3 size is wrong, did not do test.
From the driver, only the entry 'scr' of fsl_esdhc below reserved3 is
used, so the offset of scr is wrong if using `char reserved3[59]`
>
> Thanks for spotting this!
>
> Best regards,
> Marek Vasut
Regards,
Peng.
next prev parent reply other threads:[~2015-03-11 0:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 7:35 [U-Boot] [PATCH] mmc: fsl_esdhc fix register offset Peng Fan
2015-03-10 13:45 ` Marek Vasut
2015-03-11 0:58 ` Peng Fan [this message]
2015-03-11 2:03 ` Marek Vasut
2015-03-11 2:17 ` Peng Fan
2015-03-11 11:29 ` Marek Vasut
2015-03-11 13:55 ` Pantelis Antoniou
2015-03-11 14:00 ` Joakim Tjernlund
2015-03-11 16:03 ` Fabio Estevam
2015-03-11 17:46 ` Tom Rini
2015-03-11 13:00 ` Fabio Estevam
2015-03-15 5:54 ` Peng Fan
2015-03-15 14:28 ` Marek Vasut
2015-03-15 16:39 ` Joakim Tjernlund
2015-03-17 13:10 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FF933D.7050906@freescale.com \
--to=peng.fan@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox