From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peng Fan Date: Wed, 11 Mar 2015 08:58:37 +0800 Subject: [U-Boot] [PATCH] mmc: fsl_esdhc fix register offset In-Reply-To: <201503101445.40531.marex@denx.de> References: <1425972946-9555-1-git-send-email-Peng.Fan@freescale.com> <201503101445.40531.marex@denx.de> Message-ID: <54FF933D.7050906@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, Marek On 3/10/2015 9:45 PM, Marek Vasut wrote: > On Tuesday, March 10, 2015 at 08:35:46 AM, Peng Fan wrote: >> Commit f022d36e8a4517b2a9d25ff2d75bd2459d0c68b1 introduces >> error register offset. >> >> Change the "char reserved3[59]" to "char reserved3[56]". >> >> Signed-off-by: Peng Fan > This should probably be applied to 2015.04 . > > What are the symptoms of this bug please ? I just found the reserved3 size is wrong, did not do test. From the driver, only the entry 'scr' of fsl_esdhc below reserved3 is used, so the offset of scr is wrong if using `char reserved3[59]` > > Thanks for spotting this! > > Best regards, > Marek Vasut Regards, Peng.