From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joonyoung Shim <jy0922.shim@samsung.com>
Date: Wed, 11 Mar 2015 14:44:00 +0900
Subject: [U-Boot] [PATCH] Exynos: Clock: Fix exynos5_get_periph_rate for
 I2C.
In-Reply-To: <54FEB0BD.1070800@free.fr>
References: <1424877740-30367-1-git-send-email-guillaume.gardet@free.fr>
 <54F17557.40305@samsung.com> <54FEB0BD.1070800@free.fr>
Message-ID: <54FFD620.1030300@samsung.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

On 03/10/2015 05:52 PM, Guillaume Gardet wrote:
> 
> 
> Le 28/02/2015 08:59, Minkyu Kang a ?crit :
>> Joonyoung,
>>
>> On 26/02/15 00:22, Guillaume GARDET wrote:
>>> Commit 2e82e9252695a612ab0cbf40fa0c7368515f6506 'Exynos: Clock: Cleanup
>>> soc_get_periph_rate' introduced a bug in I2C config. This patch makes cros_ec
>>> keyboard working again on Samsung Chromebook (snow).
>>>
>>> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
>>> Cc: Akshay Saraswat <akshay.s@samsung.com>
>>> Cc: Minkyu Kang <mk7.kang@samsung.com>
>>> Cc: Joonyoung Shim <jy0922.shim@samsung.com>
>>>
>>> ---
>>>   arch/arm/cpu/armv7/exynos/clock.c | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/cpu/armv7/exynos/clock.c b/arch/arm/cpu/armv7/exynos/clock.c
>>> index c6455c2..7f47d4d 100644
>>> --- a/arch/arm/cpu/armv7/exynos/clock.c
>>> +++ b/arch/arm/cpu/armv7/exynos/clock.c
>>> @@ -423,8 +423,8 @@ static unsigned long exynos5_get_periph_rate(int peripheral)
>>>       case PERIPH_ID_I2C6:
>>>       case PERIPH_ID_I2C7:
>>>           src = EXYNOS_SRC_MPLL;
>>> -        div = readl(&clk->div_top0);
>>> -        sub_div = readl(&clk->div_top1);
>>> +        sub_div = readl(&clk->div_top0);
>>> +        div = readl(&clk->div_top1);

Could you keep order of assign statements of div and sub_div variables?

div = readl(&clk->div_top1);
sub_div = readl(&clk->div_top0);

Thanks.