From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3987C433EF for ; Mon, 13 Sep 2021 14:59:46 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFF1360F38 for ; Mon, 13 Sep 2021 14:59:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CFF1360F38 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siemens.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CBEF481FA5; Mon, 13 Sep 2021 16:59:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=siemens.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 25A958023C; Mon, 13 Sep 2021 16:59:42 +0200 (CEST) Received: from david.siemens.de (david.siemens.de [192.35.17.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 27B7581FA5 for ; Mon, 13 Sep 2021 16:59:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=siemens.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id 18DExaoi010066 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Sep 2021 16:59:37 +0200 Received: from [139.22.39.76] ([139.22.39.76]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 18DExaMd011545; Mon, 13 Sep 2021 16:59:36 +0200 Subject: Re: [PATCH v7 5/5] iot2050: Enable watchdog support, but do not auto-start it To: Tom Rini Cc: U-Boot Mailing List , Le Jin , Bao Cheng Su , Nian Gao , Chao Zeng , Lokesh Vutla References: <44b858e8826f4617439aec11ad850431e4bc1a21.1628000645.git.jan.kiszka@siemens.com> <20210911001003.GA2638@bill-the-cat> <0fd4c0d4-c42f-bb15-b68b-3ccf9a9037e0@siemens.com> <20210913123445.GB12964@bill-the-cat> <5d515165-6f39-285d-7bd1-a412ed468cf4@siemens.com> <20210913145609.GO12964@bill-the-cat> From: Jan Kiszka Message-ID: <54d40bce-3baf-e485-3467-863eca5bf296@siemens.com> Date: Mon, 13 Sep 2021 16:59:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210913145609.GO12964@bill-the-cat> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 13.09.21 16:56, Tom Rini wrote: > On Mon, Sep 13, 2021 at 04:31:37PM +0200, Jan Kiszka wrote: >> On 13.09.21 14:34, Tom Rini wrote: >>> On Mon, Sep 13, 2021 at 09:57:45AM +0200, Jan Kiszka wrote: >>>> On 11.09.21 02:10, Tom Rini wrote: >>>>> On Tue, Aug 03, 2021 at 04:24:05PM +0200, Jan Kiszka wrote: >>>>> >>>>>> From: Jan Kiszka >>>>>> >>>>>> This allows to use the watchdog in custom scripts but does not enforce >>>>>> that the OS has to support it as well. >>>>>> >>>>>> Signed-off-by: Jan Kiszka >>>>> >>>>> Sorry for the late reply. This causes CI to fail: >>>>> Building current source for 1 boards (1 thread, 16 jobs per thread) >>>>> aarch64: + iot2050 >>>>> +(iot2050) WARNING ATF file bl31.bin NOT found, resulting binary is non-functional >>>>> +(iot2050) WARNING OPTEE file bl32.bin NOT found, resulting might be non-functional >>>>> +(iot2050) binman: Filename 'k3-rti-wdt.fw' not found in input path (.,/home/trini/work/u-boot/u-boot,board/siemens/iot2050,arch/arm/dts) (cwd='/tmp/iot2050/.bm-work/iot2050') >>>>> +(iot2050) make[1]: *** [all] Error 1 >>>>> +(iot2050) make: *** [sub-make] Error 2 >>>>> 0 0 1 /1 iot2050 >>>>> >>>>> And needs to be handled like ATF/OPTEE/etc where CI can build but throw >>>>> a "THIS WILL NOT RUN CORRECTLY" type warning to the user. >>>>> >>>> >>>> I was about to sent an update anyway - time passed, and now we even have >>>> support for the next generation integrated from the beginning. But >>>> related upstream DT changes are not yet merged. >>> >>> OK. >>> >>>> But back to this issue: How can CI be fed with all those required >>>> binaries? The build makes no sense in their absence. >>> >>> To be clearer, CI isn't fed all of the binaries, we just use /dev/null >>> in that case and try and make it clear it won't boot. K3 isn't a good >>> example here, but I think sunxi uses binman and handles this same class >>> of problem? >>> >> >> I'm seeing it additionally carrying a "missing-msg" property, but that >> alone (even with missing-blob-help updated) does not make the build >> pass. It rather seems I'm missing some "allow_missing" property for that >> image, but even reading the code gives no clue yet how to achieve that. >> Yet another binman mystery. > > You might also need a new file in tools/binman/etype/ ? Also, it will > have a non-zero exit status still, but with a value of 101 which we > check for and know that's "binary blob missing" and so OK to allow CI to > pass on. > Err, that doesn't sound like binman is making my life easier. Why can't a I simple do something like k3-rti-wdt-firmware { type = "blob"; load = <0x82000000>; blob { filename = CONFIG_WDT_K3_RTI_FW_FILE; missing-msg = "k3-rti-wdt-firmware"; allow_missing; }; }; and be done? Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux