* [U-Boot] [PATCH 1/2] mx6_common: Do not select esdhc DDR mode for all boards
@ 2015-03-12 1:52 Fabio Estevam
2015-03-12 1:52 ` [U-Boot] [PATCH 2/2] warp: Select CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE Fabio Estevam
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Fabio Estevam @ 2015-03-12 1:52 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE should be selected only by boards that really
have a DDR-capable eMMC, so remove this option from common code to avoid
regressions.
Reported-by: Stefan Roese <sr@denx.de>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
include/configs/mx6_common.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/configs/mx6_common.h b/include/configs/mx6_common.h
index 29b72b2..e0528ce 100644
--- a/include/configs/mx6_common.h
+++ b/include/configs/mx6_common.h
@@ -28,8 +28,6 @@
#define CONFIG_SYS_PL310_BASE L2_PL310_BASE
#endif
-#define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
-
#define CONFIG_MP
#define CONFIG_MXC_GPT_HCLK
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [U-Boot] [PATCH 2/2] warp: Select CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
2015-03-12 1:52 [U-Boot] [PATCH 1/2] mx6_common: Do not select esdhc DDR mode for all boards Fabio Estevam
@ 2015-03-12 1:52 ` Fabio Estevam
2015-03-12 3:48 ` Otavio Salvador
2015-03-13 12:36 ` Stefano Babic
2015-03-12 3:48 ` [U-Boot] [PATCH 1/2] mx6_common: Do not select esdhc DDR mode for all boards Otavio Salvador
` (2 subsequent siblings)
3 siblings, 2 replies; 8+ messages in thread
From: Fabio Estevam @ 2015-03-12 1:52 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
Warp has a DDR eMMC, so enable CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE for better
performance:
reading zImage
5790288 bytes read in 117 ms (47.2 MiB/s)
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
include/configs/warp.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/configs/warp.h b/include/configs/warp.h
index bcdd112..16cda74 100644
--- a/include/configs/warp.h
+++ b/include/configs/warp.h
@@ -42,6 +42,7 @@
#define CONFIG_FSL_USDHC
#define CONFIG_SYS_FSL_ESDHC_ADDR 0
#define CONFIG_SYS_FSL_ESDHC_FORCE_VSELECT
+#define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
#define CONFIG_MMC
#define CONFIG_CMD_MMC
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [U-Boot] [PATCH 2/2] warp: Select CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
2015-03-12 1:52 ` [U-Boot] [PATCH 2/2] warp: Select CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE Fabio Estevam
@ 2015-03-12 3:48 ` Otavio Salvador
2015-03-13 12:36 ` Stefano Babic
1 sibling, 0 replies; 8+ messages in thread
From: Otavio Salvador @ 2015-03-12 3:48 UTC (permalink / raw)
To: u-boot
On Wed, Mar 11, 2015 at 10:52 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Warp has a DDR eMMC, so enable CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE for better
> performance:
>
> reading zImage
> 5790288 bytes read in 117 ms (47.2 MiB/s)
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Otavio Salvador <otavio@ossystems.com.br>
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 2/2] warp: Select CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
2015-03-12 1:52 ` [U-Boot] [PATCH 2/2] warp: Select CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE Fabio Estevam
2015-03-12 3:48 ` Otavio Salvador
@ 2015-03-13 12:36 ` Stefano Babic
1 sibling, 0 replies; 8+ messages in thread
From: Stefano Babic @ 2015-03-13 12:36 UTC (permalink / raw)
To: u-boot
On 12/03/2015 02:52, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Warp has a DDR eMMC, so enable CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE for better
> performance:
>
> reading zImage
> 5790288 bytes read in 117 ms (47.2 MiB/s)
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 1/2] mx6_common: Do not select esdhc DDR mode for all boards
2015-03-12 1:52 [U-Boot] [PATCH 1/2] mx6_common: Do not select esdhc DDR mode for all boards Fabio Estevam
2015-03-12 1:52 ` [U-Boot] [PATCH 2/2] warp: Select CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE Fabio Estevam
@ 2015-03-12 3:48 ` Otavio Salvador
2015-03-12 4:42 ` Volodymyr Riazantsev
2015-03-12 8:29 ` Stefan Roese
2015-03-13 12:36 ` Stefano Babic
3 siblings, 1 reply; 8+ messages in thread
From: Otavio Salvador @ 2015-03-12 3:48 UTC (permalink / raw)
To: u-boot
On Wed, Mar 11, 2015 at 10:52 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE should be selected only by boards that really
> have a DDR-capable eMMC, so remove this option from common code to avoid
> regressions.
>
> Reported-by: Stefan Roese <sr@denx.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Otavio Salvador <otavio@ossystems.com.br>
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 1/2] mx6_common: Do not select esdhc DDR mode for all boards
2015-03-12 3:48 ` [U-Boot] [PATCH 1/2] mx6_common: Do not select esdhc DDR mode for all boards Otavio Salvador
@ 2015-03-12 4:42 ` Volodymyr Riazantsev
0 siblings, 0 replies; 8+ messages in thread
From: Volodymyr Riazantsev @ 2015-03-12 4:42 UTC (permalink / raw)
To: u-boot
On Wed, Mar 11, 2015 at 11:48 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Wed, Mar 11, 2015 at 10:52 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE should be selected only by boards that really
>> have a DDR-capable eMMC, so remove this option from common code to avoid
>> regressions.
>>
>> Reported-by: Stefan Roese <sr@denx.de>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
>
> Acked-by: Otavio Salvador <otavio@ossystems.com.br>
Reviewed-by: Volodymyr Riazantsev <volodymyr.riazantsev@globallogic.com>
>
> --
> Otavio Salvador O.S. Systems
> http://www.ossystems.com.br http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
Volodymyr Riazantsev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 1/2] mx6_common: Do not select esdhc DDR mode for all boards
2015-03-12 1:52 [U-Boot] [PATCH 1/2] mx6_common: Do not select esdhc DDR mode for all boards Fabio Estevam
2015-03-12 1:52 ` [U-Boot] [PATCH 2/2] warp: Select CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE Fabio Estevam
2015-03-12 3:48 ` [U-Boot] [PATCH 1/2] mx6_common: Do not select esdhc DDR mode for all boards Otavio Salvador
@ 2015-03-12 8:29 ` Stefan Roese
2015-03-13 12:36 ` Stefano Babic
3 siblings, 0 replies; 8+ messages in thread
From: Stefan Roese @ 2015-03-12 8:29 UTC (permalink / raw)
To: u-boot
On 12.03.2015 02:52, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE should be selected only by boards that really
> have a DDR-capable eMMC, so remove this option from common code to avoid
> regressions.
>
> Reported-by: Stefan Roese <sr@denx.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
These 2 patches fix this DDR issue on my board. So:
Tested-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 1/2] mx6_common: Do not select esdhc DDR mode for all boards
2015-03-12 1:52 [U-Boot] [PATCH 1/2] mx6_common: Do not select esdhc DDR mode for all boards Fabio Estevam
` (2 preceding siblings ...)
2015-03-12 8:29 ` Stefan Roese
@ 2015-03-13 12:36 ` Stefano Babic
3 siblings, 0 replies; 8+ messages in thread
From: Stefano Babic @ 2015-03-13 12:36 UTC (permalink / raw)
To: u-boot
On 12/03/2015 02:52, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE should be selected only by boards that really
> have a DDR-capable eMMC, so remove this option from common code to avoid
> regressions.
>
> Reported-by: Stefan Roese <sr@denx.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-03-13 12:36 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-12 1:52 [U-Boot] [PATCH 1/2] mx6_common: Do not select esdhc DDR mode for all boards Fabio Estevam
2015-03-12 1:52 ` [U-Boot] [PATCH 2/2] warp: Select CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE Fabio Estevam
2015-03-12 3:48 ` Otavio Salvador
2015-03-13 12:36 ` Stefano Babic
2015-03-12 3:48 ` [U-Boot] [PATCH 1/2] mx6_common: Do not select esdhc DDR mode for all boards Otavio Salvador
2015-03-12 4:42 ` Volodymyr Riazantsev
2015-03-12 8:29 ` Stefan Roese
2015-03-13 12:36 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox