public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] arm: mx6: tqma6: Update to optionally configure an alternative SPI setup
Date: Thu, 12 Mar 2015 16:18:57 +0100	[thread overview]
Message-ID: <5501AE61.2060603@denx.de> (raw)
In-Reply-To: <5501A1CE.7090902@tqsc.de>

Hi Markus,

On 12.03.2015 15:25, Markus Niebel wrote:
> Am 12.03.2015 um 13:34 schrieb Stefan Roese:
>> By making the tqma6_iomuxc_spi() weak, this patch adds the possibility to
>> add a different function for this SPI configuration. This can be used
>> by other baseboards, that might have a different SPI setup.
>>
>> This patch will be used by the upcoming WRU-IV board support which also
>> uses the TQMa6 SoM.
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> ---
>>   board/tqc/tqma6/tqma6.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/board/tqc/tqma6/tqma6.c b/board/tqc/tqma6/tqma6.c
>> index c9e163e..29db838 100644
>> --- a/board/tqc/tqma6/tqma6.c
>> +++ b/board/tqc/tqma6/tqma6.c
>> @@ -145,7 +145,7 @@ static unsigned const tqma6_ecspi1_cs[] = {
>>   	TQMA6_SF_CS_GPIO,
>>   };
>>
>> -static void tqma6_iomuxc_spi(void)
>> +__weak void tqma6_iomuxc_spi(void)
>>   {
>>   	unsigned i;
>>
> When implementing an baseboard specific init handler, we will get
 > a warning about unused
> tqma6_ecspi1_pads and tqma6_ecspi1_cs, or did I miss something?

I'm not getting one with the current (unfinished) WRU4 baseboard. Which 
has no SPI.

> Just as a thought (not ready): Could we supply CS initialisation
 > data via defines in the
> baseboard config header and append it to the tables if needed?

Not sure if I understand this correctly. Could you give an example? 
Again, my current baseboard has no SPI at all.

Thanks,
Stefan

  reply	other threads:[~2015-03-12 15:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12 12:34 [U-Boot] [PATCH 1/3] arm: mx6: tqma6: Fix USB and add other filesystems Stefan Roese
2015-03-12 12:34 ` [U-Boot] [PATCH 2/3] arm: mx6: tqma6: Update to optionally configure an alternative SPI setup Stefan Roese
2015-03-12 14:25   ` Markus Niebel
2015-03-12 15:18     ` Stefan Roese [this message]
2015-03-13  9:05       ` Markus Niebel
2015-03-13 13:25         ` Stefan Roese
2015-03-13 13:27           ` Stefan Roese
2015-03-13 16:52           ` Markus Niebel
2015-05-05  9:37   ` Stefan Roese
2015-05-05 15:17     ` Stefano Babic
2015-03-12 12:34 ` [U-Boot] [PATCH 3/3] arm: mx6: tqma6: Extract baseboard configs into separate config file Stefan Roese
2015-03-12 14:17   ` Markus Niebel
2015-03-12 15:24     ` Stefan Roese
2015-03-12 14:09 ` [U-Boot] [PATCH 1/3] arm: mx6: tqma6: Fix USB and add other filesystems Markus Niebel
2015-05-05  9:36 ` Stefan Roese
2015-05-05  9:59   ` Stefano Babic
2015-05-05 15:16 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5501AE61.2060603@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox