public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm, imx: fix spl compile for mxs boards
Date: Tue, 17 Mar 2015 09:27:06 +0100	[thread overview]
Message-ID: <5507E55A.8000107@denx.de> (raw)
In-Reply-To: <1426576811-572-1-git-send-email-hs@denx.de>

Hi Heiko, Daniel,


On 17/03/2015 08:20, Heiko Schocher wrote:
> files in arch/arm/imx-common/ get not yet compiled for
> SPL case as "mxs" is missing in filter rule.
> 

This is possible, but...

> Signed-off-by: Heiko Schocher <hs@denx.de>
> 
> ---
> 
> Fixes build error on for example the mx28evk_auart_console board:
> 
> Building mx28evk_auart_console board...
>    text    data     bss     dec     hex filename
>  442689   36826  327648  807163   c50fb ./u-boot


...I do not understand why I can compile clean (u-boot-imx):

./tools/buildman/buildman mx28evk
boards.cfg is up to date. Nothing to do.
Building current source for 4 boards (4 threads, 2 jobs per thread)
    4    0    0 /4      0:00:48  : mx28evk_auart_console

And all mxb boards are compiled clean, too.

> make[1]: *** [spl/u-boot-spl] Error 1
> make: *** [spl/u-boot-spl] Error 2
> drivers/serial/built-in.o: In function `mxs_auart_init':
> /home/hs/zug/u-boot/drivers/serial/mxs_auart.c:84: undefined reference to `mxs_reset_block'
> make[1]: *** [spl/u-boot-spl] Error 1
> make: *** [spl/u-boot-spl] Error 2
> make: *** Warte auf noch nicht beendete Prozesse...
> 
>  arch/arm/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 08946de..55fe509 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -37,7 +37,7 @@ libs-y += arch/arm/cpu/
>  libs-y += arch/arm/lib/
>  
>  ifeq ($(CONFIG_SPL_BUILD),y)
> -ifneq (,$(CONFIG_MX23)$(CONFIG_MX35)$(filter $(SOC), mx25 mx27 mx5 mx6 mx31 mx35))
> +ifneq (,$(CONFIG_MX23)$(CONFIG_MX35)$(filter $(SOC), mx25 mx27 mx5 mx6 mx31 mx35 mxs))
>  libs-y += arch/arm/imx-common/
>  endif
>  else

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2015-03-17  8:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-17  7:20 [U-Boot] [PATCH] arm, imx: fix spl compile for mxs boards Heiko Schocher
2015-03-17  8:27 ` Stefano Babic [this message]
2015-03-17  9:40   ` Heiko Schocher
2015-06-19 12:14   ` Craig Lilley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5507E55A.8000107@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox