From: Holger Brunck <holger.brunck@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] bootcount: Add dcache flush to bootcount_store()
Date: Tue, 17 Mar 2015 10:00:13 +0100 [thread overview]
Message-ID: <5507ED1D.7090005@keymile.com> (raw)
In-Reply-To: <20150313143403.GE32541@bill-the-cat>
Hi Tom,
On 03/13/2015 03:34 PM, Tom Rini wrote:
> On Fri, Mar 13, 2015 at 09:48:56AM -0400, Tom Rini wrote:
>> On Wed, Mar 11, 2015 at 09:51:38AM +0100, Stefan Roese wrote:
>>
>>> Without this dcache_flush the updated bootcounter may not be saved to
>>> its location.
>>>
>>> This was detected on an iMX.6 platform using the OCRAM (internal SRAM)
>>> as bootcounter storage area. And issuing "reset" from within U-Boot
>>> cause the bootcounter to stay on its initial value.
>>>
>>> Signed-off-by: Stefan Roese <sr@denx.de>
>>> Reviewed-by: Tom Rini <trini@konsulko.com>
>>
>> OK, this breaks some platforms:
>> powerpc: + TQM850L
>> +(TQM850L) drivers/built-in.o: In function `bootcount_store':
>> +(TQM850L) build/../drivers/bootcount/bootcount.c:64: undefined reference to `flush_dcache_range'
>> +(TQM850L) make[1]: *** [u-boot] Error 1
>> +(TQM850L) make: *** [sub-make] Error 2
>>
>> We'll see how many others have the same problem soon and then I'll
>> decide on nuking the old platforms of holding off on this change.
>
> Aside from the TQM 8xx family that Wolfgang owns we have mgcoge and
> mgcoge3ne also breaking from this
> (http://patchwork.ozlabs.org/patch/448849/) change. Wolfgang, Holger,
> how do you want to proceed? We either need cache operations or dropping
> bootcount from the platforms or dropping the platforms.
>
we still would like to keep mgcoge and mgcoge3ne support. These boards are still
in maintenance. Unfortunately this week we are very busy. Next week Valentin or
myself have planned to find some time to look at this.
Regards
Holger
next prev parent reply other threads:[~2015-03-17 9:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 8:51 [U-Boot] [PATCH] autoboot.c: Add feature to stop autobooting via SHA256 encrypted password Stefan Roese
2015-03-11 8:51 ` [U-Boot] [PATCH] bootcount: Add dcache flush to bootcount_store() Stefan Roese
2015-03-11 14:39 ` Tom Rini
2015-03-13 13:48 ` [U-Boot] " Tom Rini
2015-03-13 14:34 ` Tom Rini
2015-03-15 18:30 ` Tom Rini
2015-03-16 15:57 ` York Sun
2015-03-16 17:05 ` Tom Rini
2015-03-16 17:11 ` York Sun
2015-03-16 17:22 ` Tom Rini
2015-03-17 9:00 ` Holger Brunck [this message]
2015-03-27 13:18 ` Stefan Roese
2015-03-27 13:42 ` Nitin Garg
2015-03-27 15:07 ` [U-Boot] [RFC] powerpc: add 2 common dcache assembly functions Valentin Longchamp
2015-03-28 18:07 ` Tom Rini
2015-05-05 16:35 ` [U-Boot] [U-Boot, RFC] " York Sun
2015-03-11 8:51 ` [U-Boot] [PATCH] cmd_led: Extend led command to support blinking and more leds Stefan Roese
2015-03-11 14:38 ` Tom Rini
2015-04-23 22:02 ` [U-Boot] " Tom Rini
2015-03-11 8:51 ` [U-Boot] [PATCH] misc: led: Add PCA9551 LED driver Stefan Roese
2015-03-11 14:40 ` Tom Rini
2015-03-11 14:46 ` Fabio Estevam
2015-03-11 14:36 ` [U-Boot] [PATCH] autoboot.c: Add feature to stop autobooting via SHA256 encrypted password Tom Rini
2015-03-12 8:39 ` Stefan Roese
2015-03-13 2:48 ` Simon Glass
2015-03-13 7:15 ` Stefan Roese
2015-03-23 20:28 ` Simon Glass
2015-05-05 15:06 ` Stefan Roese
2015-05-05 15:12 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5507ED1D.7090005@keymile.com \
--to=holger.brunck@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox