public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] Setting up MAC address for eth drivers
Date: Tue, 17 Mar 2015 11:16:42 +0100	[thread overview]
Message-ID: <5507FF0A.800@monstr.eu> (raw)
In-Reply-To: <BN1BFFO11OLC0024545758C93CF90357153E2070@BN1BFFO11OLC002.protection.gbl>

Hi,

any update on this one?

Thanks,
Michal

On 03/13/2015 01:25 PM, Michal Simek wrote:
> Hi,
> 
> I have a question regarding setting mac address for drivers.
> Drivers setting up write_hwaddr via eth_write_hwaddr via eth_initialize
> which is called from common/board_r.c.
> 
> But then there are some drivers(macb, designware, altera_tse) which also calls
> mac setup from dev->init which has side effect for example when you setup CONFIG_ENV_OVERWRITE
> and change mac address you can directly use it.
> 
> It also means if there is intention to call hwaddr from dev->init
> that for the first packet mac address is setup twice - in eth core init
> and then before every driver use.
> 
> I am asking this question because I would like to know the right flow
> for eth mac setup.
> If it is
> set ethaddr xx....
> saveenv
> reset
> eth with new mac
> 
> or if
> set ethaddr
> eth with new mac
> should work
> 
> The second approach looks reasonable when ethaddr is not set at all
> but then at least our driver needs to be fixed to support this feature.
> 
> Thanks,
> Michal
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
> 


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150317/68647c18/attachment.sig>

  reply	other threads:[~2015-03-17 10:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13 12:25 [U-Boot] Setting up MAC address for eth drivers Michal Simek
2015-03-17 10:16 ` Michal Simek [this message]
2015-03-17 15:56 ` Joe Hershberger
2015-03-17 16:57   ` Michal Simek
2015-03-17 17:21     ` Joe Hershberger
2015-03-17 17:47       ` Michal Simek
2015-03-23 20:22         ` Simon Glass
2015-03-24  6:49           ` [U-Boot] [PATCH v1] net: Update hardware MAC address if it changes in env Joe Hershberger
2015-03-24  6:54             ` Joe Hershberger
2015-03-24  7:41             ` [U-Boot] [PATCH v2] " Joe Hershberger
2015-03-30 18:08               ` Joe Hershberger
2015-03-31 11:41                 ` Michal Simek
2015-04-21 23:21                   ` Joe Hershberger
2015-06-15  9:07             ` [U-Boot] [PATCH v1] " Bin Meng
2015-06-15 10:42               ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5507FF0A.800@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox