From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Wed, 18 Mar 2015 10:14:05 +0100 Subject: [U-Boot] [PATCH v2] i2c: mvtwsi: Fix problem with baud rate calculation In-Reply-To: <1426667454-9344-1-git-send-email-sr@denx.de> References: <1426667454-9344-1-git-send-email-sr@denx.de> Message-ID: <550941DD.1020309@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Stefan, Am 18.03.2015 09:30, schrieb Stefan Roese: > The current implementation for baudrate calculation is incorrect. > This part from the formula: > > "2 ^ (n + 1)" is not equivalent to (1 << n) but to (2 << n)! > > This patch fixes this and moves this calculation to a function instead of using a macro. > This new function is taken from the Linux kernel. > > This was detected and tested on the Marvell Armada A38x DB-88F6820-GP eval board. > > Signed-off-by: Stefan Roese > Cc: Prafulla Wadaskar > Cc: Luka Perkov > Cc: Hans de Goede > Cc: Ian Campbell > Cc: Heiko Schocher > --- > v2: > - Still use the old formula for SUNXI, as this was checked > by Hans with Allwinner to be the correct formula. This means > that the Linux baudrate is incorrect for SUNXI I2C though. > > drivers/i2c/mvtwsi.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) Thanks! Applied to u-boot-i2c.git bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany