From mboxrd@z Thu Jan  1 00:00:00 1970
From: Igor Grinberg <grinberg@compulab.co.il>
Date: Wed, 18 Mar 2015 14:11:43 +0200
Subject: [U-Boot] [PATCH v2 3/4] common/lcd_console: move single static
 variables into common (static) structure
In-Reply-To: <1426664243-30998-4-git-send-email-oe5hpm@oevsv.at>
References: <1426664243-30998-1-git-send-email-oe5hpm@oevsv.at>
 <1426664243-30998-4-git-send-email-oe5hpm@oevsv.at>
Message-ID: <55096B7F.3090707@compulab.co.il>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


On 03/18/15 09:37, Hannes Petermaier wrote:
> From: Hannes Petermaier <hannes.petermaier@br-automation.com>
> 
> For coming implementation of lcd_console rotation, we will need some more
> variables for holding information about framebuffer size, rotation, ...
> 
> For better readability we catch all them into a common structure.
> 
> Signed-off-by: Hannes Petermaier <hannes.petermaier@br-automation.com>
> Signed-off-by: Hannes Petermaier <oe5hpm@oevsv.at>
> ---
> 
> Changes in v2: None
> 
>  common/lcd_console.c |   76 +++++++++++++++++++++++++-------------------------
>  1 file changed, 38 insertions(+), 38 deletions(-)
> 
> diff --git a/common/lcd_console.c b/common/lcd_console.c
> index b7dda7a..cac77be 100644
> --- a/common/lcd_console.c
> +++ b/common/lcd_console.c

[...]

> +struct console_t {
> +	short curr_col, curr_row;
> +	short cols, rows;
> +	void *lcd_address;

Shouldn't this be fbbase?

> +};
> +static struct console_t cons;

[...]

-- 
Regards,
Igor.