From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hannes Petermaier <hannes@petermaier.org>
Date: Wed, 18 Mar 2015 13:14:14 +0100
Subject: [U-Boot] [PATCH v2 3/4] common/lcd_console: move single static
 variables into common (static) structure
In-Reply-To: <55096B7F.3090707@compulab.co.il>
References: <1426664243-30998-1-git-send-email-oe5hpm@oevsv.at>
 <1426664243-30998-4-git-send-email-oe5hpm@oevsv.at>
 <55096B7F.3090707@compulab.co.il>
Message-ID: <55096C16.3010907@petermaier.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 2015-03-18 13:11, Igor Grinberg wrote:
> [...]
>> +struct console_t {
>> +	short curr_col, curr_row;
>> +	short cols, rows;
>> +	void *lcd_address;
> Shouldn't this be fbbase?
>
>> +};
>> +static struct console_t cons;
> [...]
>
Hi Igor,
my plan was/is to make a cleanup patch after this story is closed.
- remove empty lines in code
- rename some variables

would it be better to do that immediately ?

best regards,
Hannes