* [U-Boot] [PATCH] cmd_mem: Store last address/size/etc as ulong
@ 2015-03-19 16:43 York Sun
2015-03-19 17:50 ` Simon Glass
0 siblings, 1 reply; 4+ messages in thread
From: York Sun @ 2015-03-19 16:43 UTC (permalink / raw)
To: u-boot
From: Scott Wood <scottwood@freescale.com>
Otherwise the high 32 bits get truncated on 64-bit U-boot.
Signed-off-by: Scott Wood <scottwood@freescale.com>
CC: Simon Glass <sjg@chromium.org>
---
common/cmd_mem.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/common/cmd_mem.c b/common/cmd_mem.c
index bcb3ee3..62a0404 100644
--- a/common/cmd_mem.c
+++ b/common/cmd_mem.c
@@ -35,9 +35,9 @@ static int mod_mem(cmd_tbl_t *, int, int, int, char * const []);
/* Display values from last command.
* Memory modify remembered values are different from display memory.
*/
-static uint dp_last_addr, dp_last_size;
-static uint dp_last_length = 0x40;
-static uint mm_last_addr, mm_last_size;
+static ulong dp_last_addr, dp_last_size;
+static ulong dp_last_length = 0x40;
+static ulong mm_last_addr, mm_last_size;
static ulong base_address = 0;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] cmd_mem: Store last address/size/etc as ulong
2015-03-19 16:43 [U-Boot] [PATCH] cmd_mem: Store last address/size/etc as ulong York Sun
@ 2015-03-19 17:50 ` Simon Glass
2015-03-19 17:54 ` York Sun
2015-04-23 23:39 ` York Sun
0 siblings, 2 replies; 4+ messages in thread
From: Simon Glass @ 2015-03-19 17:50 UTC (permalink / raw)
To: u-boot
On 19 March 2015 at 10:43, York Sun <yorksun@freescale.com> wrote:
> From: Scott Wood <scottwood@freescale.com>
>
> Otherwise the high 32 bits get truncated on 64-bit U-boot.
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> CC: Simon Glass <sjg@chromium.org>
> ---
> common/cmd_mem.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/common/cmd_mem.c b/common/cmd_mem.c
> index bcb3ee3..62a0404 100644
> --- a/common/cmd_mem.c
> +++ b/common/cmd_mem.c
> @@ -35,9 +35,9 @@ static int mod_mem(cmd_tbl_t *, int, int, int, char * const []);
> /* Display values from last command.
> * Memory modify remembered values are different from display memory.
> */
> -static uint dp_last_addr, dp_last_size;
> -static uint dp_last_length = 0x40;
> -static uint mm_last_addr, mm_last_size;
> +static ulong dp_last_addr, dp_last_size;
> +static ulong dp_last_length = 0x40;
> +static ulong mm_last_addr, mm_last_size;
>
> static ulong base_address = 0;
Reviewed-by: Simon Glass <sjg@chromium.org>
>
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] cmd_mem: Store last address/size/etc as ulong
2015-03-19 17:50 ` Simon Glass
@ 2015-03-19 17:54 ` York Sun
2015-04-23 23:39 ` York Sun
1 sibling, 0 replies; 4+ messages in thread
From: York Sun @ 2015-03-19 17:54 UTC (permalink / raw)
To: u-boot
On 03/19/2015 10:50 AM, Simon Glass wrote:
> On 19 March 2015 at 10:43, York Sun <yorksun@freescale.com> wrote:
>> From: Scott Wood <scottwood@freescale.com>
>>
>> Otherwise the high 32 bits get truncated on 64-bit U-boot.
>>
>> Signed-off-by: Scott Wood <scottwood@freescale.com>
>> CC: Simon Glass <sjg@chromium.org>
>> ---
>> common/cmd_mem.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/common/cmd_mem.c b/common/cmd_mem.c
>> index bcb3ee3..62a0404 100644
>> --- a/common/cmd_mem.c
>> +++ b/common/cmd_mem.c
>> @@ -35,9 +35,9 @@ static int mod_mem(cmd_tbl_t *, int, int, int, char * const []);
>> /* Display values from last command.
>> * Memory modify remembered values are different from display memory.
>> */
>> -static uint dp_last_addr, dp_last_size;
>> -static uint dp_last_length = 0x40;
>> -static uint mm_last_addr, mm_last_size;
>> +static ulong dp_last_addr, dp_last_size;
>> +static ulong dp_last_length = 0x40;
>> +static ulong mm_last_addr, mm_last_size;
>>
>> static ulong base_address = 0;
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
Feel free to bring it in. Otherwise I will bring it in along with my other
patches, targeting 2015.07.
York
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] cmd_mem: Store last address/size/etc as ulong
2015-03-19 17:50 ` Simon Glass
2015-03-19 17:54 ` York Sun
@ 2015-04-23 23:39 ` York Sun
1 sibling, 0 replies; 4+ messages in thread
From: York Sun @ 2015-04-23 23:39 UTC (permalink / raw)
To: u-boot
On 03/19/2015 10:50 AM, Simon Glass wrote:
> On 19 March 2015 at 10:43, York Sun <yorksun@freescale.com> wrote:
>> From: Scott Wood <scottwood@freescale.com>
>>
>> Otherwise the high 32 bits get truncated on 64-bit U-boot.
>>
>> Signed-off-by: Scott Wood <scottwood@freescale.com>
>> CC: Simon Glass <sjg@chromium.org>
>> ---
>> common/cmd_mem.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/common/cmd_mem.c b/common/cmd_mem.c
>> index bcb3ee3..62a0404 100644
>> --- a/common/cmd_mem.c
>> +++ b/common/cmd_mem.c
>> @@ -35,9 +35,9 @@ static int mod_mem(cmd_tbl_t *, int, int, int, char * const []);
>> /* Display values from last command.
>> * Memory modify remembered values are different from display memory.
>> */
>> -static uint dp_last_addr, dp_last_size;
>> -static uint dp_last_length = 0x40;
>> -static uint mm_last_addr, mm_last_size;
>> +static ulong dp_last_addr, dp_last_size;
>> +static ulong dp_last_length = 0x40;
>> +static ulong mm_last_addr, mm_last_size;
>>
>> static ulong base_address = 0;
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to fsl-qoriq master, awaiting upstream.
York
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-04-23 23:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-19 16:43 [U-Boot] [PATCH] cmd_mem: Store last address/size/etc as ulong York Sun
2015-03-19 17:50 ` Simon Glass
2015-03-19 17:54 ` York Sun
2015-04-23 23:39 ` York Sun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox