* [U-Boot] [PATCH] drivers/net/e1000.c: Cleanup whitespace
@ 2015-03-19 16:43 York Sun
2015-03-19 17:16 ` Joe Hershberger
0 siblings, 1 reply; 6+ messages in thread
From: York Sun @ 2015-03-19 16:43 UTC (permalink / raw)
To: u-boot
From: Minghuan Lian <Minghuan.Lian@freescale.com>
The patch removes unnecessary whitespace to fix checkpatch's
warning: unnecessary whitespace before a quoted newline
Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
CC: Joe Hershberger <joe.hershberger@ni.com>
---
drivers/net/e1000.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/e1000.c b/drivers/net/e1000.c
index cd44222..e747d97 100644
--- a/drivers/net/e1000.c
+++ b/drivers/net/e1000.c
@@ -2174,7 +2174,7 @@ e1000_copper_link_preconfig(struct e1000_hw *hw)
DEBUGOUT("Error, did not detect valid phy.\n");
return ret_val;
}
- DEBUGOUT("Phy ID = %x \n", hw->phy_id);
+ DEBUGOUT("Phy ID = %x\n", hw->phy_id);
/* Set PHY to class A mode (if necessary) */
ret_val = e1000_set_phy_mode(hw);
@@ -3485,11 +3485,11 @@ e1000_config_fc_after_link_up(struct e1000_hw *hw)
* some "sticky" (latched) bits.
*/
if (e1000_read_phy_reg(hw, PHY_STATUS, &mii_status_reg) < 0) {
- DEBUGOUT("PHY Read Error \n");
+ DEBUGOUT("PHY Read Error\n");
return -E1000_ERR_PHY;
}
if (e1000_read_phy_reg(hw, PHY_STATUS, &mii_status_reg) < 0) {
- DEBUGOUT("PHY Read Error \n");
+ DEBUGOUT("PHY Read Error\n");
return -E1000_ERR_PHY;
}
@@ -5152,7 +5152,7 @@ e1000_poll(struct eth_device *nic)
if (!(le32_to_cpu(rd->status)) & E1000_RXD_STAT_DD)
return 0;
- /*DEBUGOUT("recv: packet len=%d \n", rd->length); */
+ /* DEBUGOUT("recv: packet len=%d\n", rd->length); */
/* Packet received, make sure the data are re-loaded from RAM. */
len = le32_to_cpu(rd->length);
invalidate_dcache_range((unsigned long)packet,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] drivers/net/e1000.c: Cleanup whitespace
2015-03-19 16:43 [U-Boot] [PATCH] drivers/net/e1000.c: Cleanup whitespace York Sun
@ 2015-03-19 17:16 ` Joe Hershberger
2015-03-19 17:19 ` York Sun
2015-04-23 23:39 ` York Sun
0 siblings, 2 replies; 6+ messages in thread
From: Joe Hershberger @ 2015-03-19 17:16 UTC (permalink / raw)
To: u-boot
On Thu, Mar 19, 2015 at 11:43 AM, York Sun <yorksun@freescale.com> wrote:
>
> From: Minghuan Lian <Minghuan.Lian@freescale.com>
>
> The patch removes unnecessary whitespace to fix checkpatch's
> warning: unnecessary whitespace before a quoted newline
>
> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
> CC: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Want me to pull this one through my tree?
-Joe
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] drivers/net/e1000.c: Cleanup whitespace
2015-03-19 17:16 ` Joe Hershberger
@ 2015-03-19 17:19 ` York Sun
2015-03-19 17:55 ` York Sun
2015-04-23 23:39 ` York Sun
1 sibling, 1 reply; 6+ messages in thread
From: York Sun @ 2015-03-19 17:19 UTC (permalink / raw)
To: u-boot
On 03/19/2015 10:16 AM, Joe Hershberger wrote:
> On Thu, Mar 19, 2015 at 11:43 AM, York Sun <yorksun@freescale.com
> <mailto:yorksun@freescale.com>> wrote:
>>
>> From: Minghuan Lian <Minghuan.Lian@freescale.com
> <mailto:Minghuan.Lian@freescale.com>>
>>
>> The patch removes unnecessary whitespace to fix checkpatch's
>> warning: unnecessary whitespace before a quoted newline
>>
>> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com
> <mailto:Minghuan.Lian@freescale.com>>
>> CC: Joe Hershberger <joe.hershberger at ni.com <mailto:joe.hershberger@ni.com>>
>
> Acked-by: Joe Hershberger <joe.hershberger at ni.com <mailto:joe.hershberger@ni.com>>
>
> Want me to pull this one through my tree?
>
>
No. Your ack is good enough. I will pull it in along with other patches.
York
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] drivers/net/e1000.c: Cleanup whitespace
2015-03-19 17:19 ` York Sun
@ 2015-03-19 17:55 ` York Sun
2015-03-19 18:04 ` Joe Hershberger
0 siblings, 1 reply; 6+ messages in thread
From: York Sun @ 2015-03-19 17:55 UTC (permalink / raw)
To: u-boot
On 03/19/2015 10:19 AM, York Sun wrote:
>
>
> On 03/19/2015 10:16 AM, Joe Hershberger wrote:
>> On Thu, Mar 19, 2015 at 11:43 AM, York Sun <yorksun@freescale.com
>> <mailto:yorksun@freescale.com>> wrote:
>>>
>>> From: Minghuan Lian <Minghuan.Lian@freescale.com
>> <mailto:Minghuan.Lian@freescale.com>>
>>>
>>> The patch removes unnecessary whitespace to fix checkpatch's
>>> warning: unnecessary whitespace before a quoted newline
>>>
>>> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com
>> <mailto:Minghuan.Lian@freescale.com>>
>>> CC: Joe Hershberger <joe.hershberger at ni.com <mailto:joe.hershberger@ni.com>>
>>
>> Acked-by: Joe Hershberger <joe.hershberger at ni.com <mailto:joe.hershberger@ni.com>>
>>
>> Want me to pull this one through my tree?
>>
>>
>
> No. Your ack is good enough. I will pull it in along with other patches.
>
A second thought, if you can bring it in for 2015.04, feel free to do so.
Otherwise I will bring it in along with my other patches, targeting 2015.07.
York
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] drivers/net/e1000.c: Cleanup whitespace
2015-03-19 17:55 ` York Sun
@ 2015-03-19 18:04 ` Joe Hershberger
0 siblings, 0 replies; 6+ messages in thread
From: Joe Hershberger @ 2015-03-19 18:04 UTC (permalink / raw)
To: u-boot
On Thu, Mar 19, 2015 at 12:55 PM, York Sun <yorksun@freescale.com> wrote:
>
> On 03/19/2015 10:19 AM, York Sun wrote:
> >
> >
> > On 03/19/2015 10:16 AM, Joe Hershberger wrote:
> >> On Thu, Mar 19, 2015 at 11:43 AM, York Sun <yorksun@freescale.com
> >> <mailto:yorksun@freescale.com>> wrote:
> >>>
> >>> From: Minghuan Lian <Minghuan.Lian@freescale.com
> >> <mailto:Minghuan.Lian@freescale.com>>
> >>>
> >>> The patch removes unnecessary whitespace to fix checkpatch's
> >>> warning: unnecessary whitespace before a quoted newline
> >>>
> >>> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com
> >> <mailto:Minghuan.Lian@freescale.com>>
> >>> CC: Joe Hershberger <joe.hershberger at ni.com <mailto:
joe.hershberger@ni.com>>
> >>
> >> Acked-by: Joe Hershberger <joe.hershberger at ni.com <mailto:
joe.hershberger@ni.com>>
> >>
> >> Want me to pull this one through my tree?
> >>
> >>
> >
> > No. Your ack is good enough. I will pull it in along with other patches.
> >
>
> A second thought, if you can bring it in for 2015.04, feel free to do so.
> Otherwise I will bring it in along with my other patches, targeting
2015.07.
It wouldn't be for 2015.04. Go ahead and take it along with your other
patches.
-Joe
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] drivers/net/e1000.c: Cleanup whitespace
2015-03-19 17:16 ` Joe Hershberger
2015-03-19 17:19 ` York Sun
@ 2015-04-23 23:39 ` York Sun
1 sibling, 0 replies; 6+ messages in thread
From: York Sun @ 2015-04-23 23:39 UTC (permalink / raw)
To: u-boot
On 03/19/2015 10:16 AM, Joe Hershberger wrote:
> On Thu, Mar 19, 2015 at 11:43 AM, York Sun <yorksun@freescale.com
> <mailto:yorksun@freescale.com>> wrote:
>>
>> From: Minghuan Lian <Minghuan.Lian@freescale.com
> <mailto:Minghuan.Lian@freescale.com>>
>>
>> The patch removes unnecessary whitespace to fix checkpatch's
>> warning: unnecessary whitespace before a quoted newline
>>
>> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com
> <mailto:Minghuan.Lian@freescale.com>>
>> CC: Joe Hershberger <joe.hershberger at ni.com <mailto:joe.hershberger@ni.com>>
>
> Acked-by: Joe Hershberger <joe.hershberger at ni.com <mailto:joe.hershberger@ni.com>>
>
Applied to fsl-qoriq master, awaiting upstream.
York
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-04-23 23:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-19 16:43 [U-Boot] [PATCH] drivers/net/e1000.c: Cleanup whitespace York Sun
2015-03-19 17:16 ` Joe Hershberger
2015-03-19 17:19 ` York Sun
2015-03-19 17:55 ` York Sun
2015-03-19 18:04 ` Joe Hershberger
2015-04-23 23:39 ` York Sun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox