From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marc Zyngier <marc.zyngier@arm.com>
Date: Fri, 20 Mar 2015 18:06:01 +0000
Subject: [U-Boot] [PATCH 1/6] armv8/cache: Fix page table creation
In-Reply-To: <1426852073-10299-1-git-send-email-thierry.reding@gmail.com>
References: <1426852073-10299-1-git-send-email-thierry.reding@gmail.com>
Message-ID: <550C6189.2080900@arm.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 20/03/15 11:47, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> While generating the page tables, a running integer index is shifted by
> SECTION_SHIFT (29) and causes overflow for any integer bigger than 7.
> The page tables therefore alias to the same 8 sections and cause U-Boot
> to hang once the MMU is enabled.
> 
> Fix this by making the index a 64-bit unsigned integer and so avoid the
> overflow.
> 
> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Acked-by: Marc Zyngier <marc.zyngier@arm.com>

> ---
>  arch/arm/cpu/armv8/cache_v8.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv8/cache_v8.c b/arch/arm/cpu/armv8/cache_v8.c
> index c5ec5297cd39..254a629a3b8c 100644
> --- a/arch/arm/cpu/armv8/cache_v8.c
> +++ b/arch/arm/cpu/armv8/cache_v8.c
> @@ -25,9 +25,9 @@ void set_pgtable_section(u64 *page_table, u64 index, u64 section,
>  /* to activate the MMU we need to set up virtual memory */
>  static void mmu_setup(void)
>  {
> -	int i, j, el;
>  	bd_t *bd = gd->bd;
> -	u64 *page_table = (u64 *)gd->arch.tlb_addr;
> +	u64 *page_table = (u64 *)gd->arch.tlb_addr, i, j;
> +	int el;
>  
>  	/* Setup an identity-mapping for all spaces */
>  	for (i = 0; i < (PGTABLE_SIZE >> 3); i++) {
> 


-- 
Jazz is not dead. It just smells funny...