public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] sunxi: Ainol AW1 support
Date: Sat, 21 Mar 2015 13:03:50 +0100	[thread overview]
Message-ID: <550D5E26.6000909@redhat.com> (raw)
In-Reply-To: <1426440562-4640-2-git-send-email-contact@paulk.fr>

Hi,

On 15-03-15 18:29, Paul Kocialkowski wrote:
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
>   board/sunxi/MAINTAINERS     |  5 +++++
>   configs/Ainol_AW1_defconfig | 16 ++++++++++++++++
>   2 files changed, 21 insertions(+)
>   create mode 100644 configs/Ainol_AW1_defconfig
>
> diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS
> index ef3c937..e486458 100644
> --- a/board/sunxi/MAINTAINERS
> +++ b/board/sunxi/MAINTAINERS
> @@ -50,6 +50,11 @@ S:	Maintained
>   F:	board/sunxi/dram_a20_olinuxino_l2.c
>   F:	configs/A20-OLinuXino-Lime2_defconfig
>
> +AINOL AW1 BOARD
> +M:	Paul Kocialkowski <contact@paulk.fr>
> +S:	Maintained
> +F:	configs/Ainol_AW1_defconfig
> +
>   AMPE A76 BOARD
>   M:	Paul Kocialkowski <contact@paulk.fr>
>   S:	Maintained
> diff --git a/configs/Ainol_AW1_defconfig b/configs/Ainol_AW1_defconfig
> new file mode 100644
> index 0000000..e37e6c8
> --- /dev/null
> +++ b/configs/Ainol_AW1_defconfig
> @@ -0,0 +1,16 @@
> +CONFIG_SPL=y
> +CONFIG_SYS_EXTRA_OPTIONS="AXP209_POWER"
> +CONFIG_FDTFILE="sun7i-a20-ainol-aw1.dtb"
> +CONFIG_USB_MUSB_SUNXI=y
> +CONFIG_USB0_VBUS_PIN="PB9"
> +CONFIG_USB0_VBUS_DET="axp_vbus_detect"
> +CONFIG_VIDEO_LCD_MODE="x:800,y:480,depth:18,pclk_khz:40000,le:87,ri:112,up:38,lo:141,hs:1,vs:1,sync:3,vmode:0"
> +CONFIG_VIDEO_LCD_POWER="PH8"
> +CONFIG_VIDEO_LCD_BL_EN="PH7"
> +CONFIG_VIDEO_LCD_BL_PWM="PB2"
> ++S:CONFIG_ARM=y
> ++S:CONFIG_ARCH_SUNXI=y
> ++S:CONFIG_MACH_SUN7I=y
> ++S:CONFIG_DRAM_CLK=432
> ++S:CONFIG_DRAM_ZQ=123
> ++S:CONFIG_DRAM_EMR1=4
>

Thanks for the patch, looks good, but needs adjustment for the discussed
changes to treat axp vbus-detect / vbus-enable as regular gpios.

Also we no longer use the +S: magic in defconfig files as there now is a
single .config for both the SPL and regular u-boot builds, so when you
resubmit together with the axp cleanups, please remove the +S: prefixes.

Regards,

Hans

  reply	other threads:[~2015-03-21 12:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-15 17:29 [U-Boot] [PATCH 1/2] power: axp209: VBUS detect Paul Kocialkowski
2015-03-15 17:29 ` [U-Boot] [PATCH 2/2] sunxi: Ainol AW1 support Paul Kocialkowski
2015-03-21 12:03   ` Hans de Goede [this message]
2015-03-21 12:01 ` [U-Boot] [PATCH 1/2] power: axp209: VBUS detect Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550D5E26.6000909@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox