From: Michal Simek <michal.simek@amd.com>
To: u-boot@lists.denx.de, git@xilinx.com
Subject: Re: [PATCH] arm64: zynqmp: Do not expose usbhub nodes
Date: Wed, 15 Nov 2023 15:10:27 +0100 [thread overview]
Message-ID: <550bc059-5d5a-4d62-8602-fefdcdd267a4@amd.com> (raw)
In-Reply-To: <537c91a7ac0843358c4e33aa10d9e035d8e92faf.1699286139.git.michal.simek@amd.com>
On 11/6/23 16:55, Michal Simek wrote:
> Upstream dwc3 U-Boot driver is not able to handle child nodes properly
> that's why comment them in DT for now. This patch should be reverted when
> dwc3 driver handles it properly.
> DT node itself is aligned with dt schema.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> arch/arm/dts/zynqmp-sck-kd-g-revA.dtso | 3 ++-
> arch/arm/dts/zynqmp-sck-kr-g-revA.dtso | 3 ++-
> arch/arm/dts/zynqmp-sck-kr-g-revB.dtso | 3 ++-
> arch/arm/dts/zynqmp-sck-kv-g-revA.dtso | 2 ++
> arch/arm/dts/zynqmp-sck-kv-g-revB.dtso | 3 ++-
> 5 files changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/dts/zynqmp-sck-kd-g-revA.dtso b/arch/arm/dts/zynqmp-sck-kd-g-revA.dtso
> index 5a5c1efd6b96..8d0ddecdc14c 100644
> --- a/arch/arm/dts/zynqmp-sck-kd-g-revA.dtso
> +++ b/arch/arm/dts/zynqmp-sck-kd-g-revA.dtso
> @@ -87,7 +87,7 @@
> phys = <&psgtr 2 PHY_TYPE_USB3 0 2>;
> reset-gpios = <&slg7xl45106 0 GPIO_ACTIVE_LOW>;
> assigned-clock-rates = <250000000>, <20000000>;
> -
> +#if 0
> usbhub0: usb-hub { /* u36 */
> i2c-bus = <&i2c1>;
> compatible = "microchip,usb5744";
> @@ -98,6 +98,7 @@
> compatible = "microchip,usb2244";
> reset-gpios = <&slg7xl45106 2 GPIO_ACTIVE_LOW>;
> };
> +#endif
> };
>
> &dwc3_0 {
> diff --git a/arch/arm/dts/zynqmp-sck-kr-g-revA.dtso b/arch/arm/dts/zynqmp-sck-kr-g-revA.dtso
> index 30a0230d4767..95b1dc5aa571 100644
> --- a/arch/arm/dts/zynqmp-sck-kr-g-revA.dtso
> +++ b/arch/arm/dts/zynqmp-sck-kr-g-revA.dtso
> @@ -139,7 +139,7 @@
> phys = <&psgtr 2 PHY_TYPE_USB3 0 2>;
> reset-gpios = <&slg7xl45106 0 GPIO_ACTIVE_LOW>;
> assigned-clock-rates = <250000000>, <20000000>;
> -
> +#if 0
> usbhub0: usb-hub { /* u43 */
> i2c-bus = <&usbhub_i2c0>;
> compatible = "microchip,usb5744";
> @@ -150,6 +150,7 @@
> compatible = "microchip,usb2244";
> reset-gpios = <&slg7xl45106 2 GPIO_ACTIVE_LOW>;
> };
> +#endif
> };
>
> &dwc3_0 {
> diff --git a/arch/arm/dts/zynqmp-sck-kr-g-revB.dtso b/arch/arm/dts/zynqmp-sck-kr-g-revB.dtso
> index 8f4c52d6d643..e2387a2abb8f 100644
> --- a/arch/arm/dts/zynqmp-sck-kr-g-revB.dtso
> +++ b/arch/arm/dts/zynqmp-sck-kr-g-revB.dtso
> @@ -139,7 +139,7 @@
> phys = <&psgtr 2 PHY_TYPE_USB3 0 2>;
> reset-gpios = <&slg7xl45106 0 GPIO_ACTIVE_LOW>;
> assigned-clock-rates = <250000000>, <20000000>;
> -
> +#if 0
> usbhub0: usb-hub { /* u43 */
> i2c-bus = <&usbhub_i2c0>;
> compatible = "microchip,usb5744";
> @@ -150,6 +150,7 @@
> compatible = "microchip,usb2244";
> reset-gpios = <&slg7xl45106 2 GPIO_ACTIVE_LOW>;
> };
> +#endif
> };
>
> &dwc3_0 {
> diff --git a/arch/arm/dts/zynqmp-sck-kv-g-revA.dtso b/arch/arm/dts/zynqmp-sck-kv-g-revA.dtso
> index c4f1da92186f..f43c159cdca9 100644
> --- a/arch/arm/dts/zynqmp-sck-kv-g-revA.dtso
> +++ b/arch/arm/dts/zynqmp-sck-kv-g-revA.dtso
> @@ -131,10 +131,12 @@
> pinctrl-0 = <&pinctrl_usb0_default>;
> phy-names = "usb3-phy";
> phys = <&psgtr 2 PHY_TYPE_USB3 0 1>;
> +#if 0
> usbhub: usb5744 { /* u43 */
> compatible = "microchip,usb5744";
> reset-gpios = <&gpio 44 GPIO_ACTIVE_LOW>;
> };
> +#endif
> };
>
> &dwc3_0 {
> diff --git a/arch/arm/dts/zynqmp-sck-kv-g-revB.dtso b/arch/arm/dts/zynqmp-sck-kv-g-revB.dtso
> index 6c5e0e566061..3643569cc7c8 100644
> --- a/arch/arm/dts/zynqmp-sck-kv-g-revB.dtso
> +++ b/arch/arm/dts/zynqmp-sck-kv-g-revB.dtso
> @@ -113,13 +113,14 @@
> phy-names = "usb3-phy";
> phys = <&psgtr 2 PHY_TYPE_USB3 0 1>;
> assigned-clock-rates = <250000000>, <20000000>;
> -
> +#if 0
> usb5744: usb-hub { /* u43 */
> status = "okay";
> compatible = "microchip,usb5744";
> i2c-bus = <&i2c1>;
> reset-gpios = <&gpio 44 GPIO_ACTIVE_LOW>;
> };
> +#endif
> };
>
> &dwc3_0 {
Applied.
M
prev parent reply other threads:[~2023-11-15 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 15:55 [PATCH] arm64: zynqmp: Do not expose usbhub nodes Michal Simek
2023-11-15 14:10 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550bc059-5d5a-4d62-8602-fefdcdd267a4@amd.com \
--to=michal.simek@amd.com \
--cc=git@xilinx.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox