* [U-Boot] [PATCH] config: Define BOOTP client architecture and VCI for ARMv8
@ 2015-03-20 12:11 Thierry Reding
2015-03-20 16:22 ` Stephen Warren
2015-03-28 18:09 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 6+ messages in thread
From: Thierry Reding @ 2015-03-20 12:11 UTC (permalink / raw)
To: u-boot
From: Thierry Reding <treding@nvidia.com>
Reuse the 32-bit ARM client architecture and identify ARMv8 specifically
by setting the BOOTP VCI string.
Cc: Dennis Gilmore <dennis@ausil.us>
Cc: Tom Rini <trini@konsulko.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
include/config_distro_defaults.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/config_distro_defaults.h b/include/config_distro_defaults.h
index f4a01ba80642..8237239c0021 100644
--- a/include/config_distro_defaults.h
+++ b/include/config_distro_defaults.h
@@ -20,10 +20,12 @@
#define CONFIG_BOOTP_PXE
#define CONFIG_BOOTP_SUBNETMASK
-#if defined(__arm__)
+#if defined(__arm__) || defined(__aarch64__)
#define CONFIG_BOOTP_PXE_CLIENTARCH 0x100
#if defined(__ARM_ARCH_7__) || defined(__ARM_ARCH_7A__)
#define CONFIG_BOOTP_VCI_STRING "U-boot.armv7"
+#elif defined(__aarch64__)
+#define CONFIG_BOOTP_VCI_STRING "U-boot.armv8"
#else
#define CONFIG_BOOTP_VCI_STRING "U-boot.arm"
#endif
--
2.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] config: Define BOOTP client architecture and VCI for ARMv8
2015-03-20 12:11 [U-Boot] [PATCH] config: Define BOOTP client architecture and VCI for ARMv8 Thierry Reding
@ 2015-03-20 16:22 ` Stephen Warren
2015-03-20 17:08 ` Tom Rini
2015-03-28 18:09 ` [U-Boot] " Tom Rini
1 sibling, 1 reply; 6+ messages in thread
From: Stephen Warren @ 2015-03-20 16:22 UTC (permalink / raw)
To: u-boot
On 03/20/2015 06:11 AM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Reuse the 32-bit ARM client architecture and identify ARMv8 specifically
> by setting the BOOTP VCI string.
Is there a newer version of https://www.rfc-editor.org/rfc/rfc4578.txt
that says what this value should be? Even 32-bit ARM isn't in that
document, so I'm not sure where 0x100 came from.
http://www.iana.org/assignments/bootp-dhcp-parameters/bootp-dhcp-parameters.txt
lists RFC4578 as the document that defines these options, so I guess
values have never been allocated for ARM?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] config: Define BOOTP client architecture and VCI for ARMv8
2015-03-20 16:22 ` Stephen Warren
@ 2015-03-20 17:08 ` Tom Rini
2015-03-23 20:07 ` Stephen Warren
0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2015-03-20 17:08 UTC (permalink / raw)
To: u-boot
On Fri, Mar 20, 2015 at 10:22:59AM -0600, Stephen Warren wrote:
> On 03/20/2015 06:11 AM, Thierry Reding wrote:
> >From: Thierry Reding <treding@nvidia.com>
> >
> >Reuse the 32-bit ARM client architecture and identify ARMv8 specifically
> >by setting the BOOTP VCI string.
>
> Is there a newer version of
> https://www.rfc-editor.org/rfc/rfc4578.txt that says what this value
> should be? Even 32-bit ARM isn't in that document, so I'm not sure
> where 0x100 came from.
I wonder if 0x100 is treated by the PXE implementations as "set but
invalid, don't use". Digging into some PXE servers would shed some
light here.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150320/69d5ea8c/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] config: Define BOOTP client architecture and VCI for ARMv8
2015-03-20 17:08 ` Tom Rini
@ 2015-03-23 20:07 ` Stephen Warren
2015-03-25 16:58 ` Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Warren @ 2015-03-23 20:07 UTC (permalink / raw)
To: u-boot
On 03/20/2015 11:08 AM, Tom Rini wrote:
> On Fri, Mar 20, 2015 at 10:22:59AM -0600, Stephen Warren wrote:
>> On 03/20/2015 06:11 AM, Thierry Reding wrote:
>>> From: Thierry Reding <treding@nvidia.com>
>>>
>>> Reuse the 32-bit ARM client architecture and identify ARMv8 specifically
>>> by setting the BOOTP VCI string.
>>
>> Is there a newer version of
>> https://www.rfc-editor.org/rfc/rfc4578.txt that says what this value
>> should be? Even 32-bit ARM isn't in that document, so I'm not sure
>> where 0x100 came from.
>
> I wonder if 0x100 is treated by the PXE implementations as "set but
> invalid, don't use". Digging into some PXE servers would shed some
> light here.
I can't actually find any use of this in ISC DHCPd. At most, it might be
a value that user config files can match against if they want. I guess
it's not worth worrying about?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] config: Define BOOTP client architecture and VCI for ARMv8
2015-03-23 20:07 ` Stephen Warren
@ 2015-03-25 16:58 ` Tom Rini
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2015-03-25 16:58 UTC (permalink / raw)
To: u-boot
On Mon, Mar 23, 2015 at 02:07:42PM -0600, Stephen Warren wrote:
> On 03/20/2015 11:08 AM, Tom Rini wrote:
> >On Fri, Mar 20, 2015 at 10:22:59AM -0600, Stephen Warren wrote:
> >>On 03/20/2015 06:11 AM, Thierry Reding wrote:
> >>>From: Thierry Reding <treding@nvidia.com>
> >>>
> >>>Reuse the 32-bit ARM client architecture and identify ARMv8 specifically
> >>>by setting the BOOTP VCI string.
> >>
> >>Is there a newer version of
> >>https://www.rfc-editor.org/rfc/rfc4578.txt that says what this value
> >>should be? Even 32-bit ARM isn't in that document, so I'm not sure
> >>where 0x100 came from.
> >
> >I wonder if 0x100 is treated by the PXE implementations as "set but
> >invalid, don't use". Digging into some PXE servers would shed some
> >light here.
>
> I can't actually find any use of this in ISC DHCPd. At most, it
> might be a value that user config files can match against if they
> want. I guess it's not worth worrying about?
Yeah, sounds like it to me.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150325/6c16ef72/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] config: Define BOOTP client architecture and VCI for ARMv8
2015-03-20 12:11 [U-Boot] [PATCH] config: Define BOOTP client architecture and VCI for ARMv8 Thierry Reding
2015-03-20 16:22 ` Stephen Warren
@ 2015-03-28 18:09 ` Tom Rini
1 sibling, 0 replies; 6+ messages in thread
From: Tom Rini @ 2015-03-28 18:09 UTC (permalink / raw)
To: u-boot
On Fri, Mar 20, 2015 at 01:11:58PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Reuse the 32-bit ARM client architecture and identify ARMv8 specifically
> by setting the BOOTP VCI string.
>
> Cc: Dennis Gilmore <dennis@ausil.us>
> Cc: Tom Rini <trini@konsulko.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150328/fb92dc81/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-28 18:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-20 12:11 [U-Boot] [PATCH] config: Define BOOTP client architecture and VCI for ARMv8 Thierry Reding
2015-03-20 16:22 ` Stephen Warren
2015-03-20 17:08 ` Tom Rini
2015-03-23 20:07 ` Stephen Warren
2015-03-25 16:58 ` Tom Rini
2015-03-28 18:09 ` [U-Boot] " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox