public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: axp209: fix incorrect limits on ldo3
Date: Thu, 26 Mar 2015 13:26:48 +0100	[thread overview]
Message-ID: <5513FB08.1080303@redhat.com> (raw)
In-Reply-To: <5512DC4E.50507@gmail.com>

Hi,

On 25-03-15 17:03, Iain Paton wrote:
> board/sunxi/board.c tries to set ldo3 to 2.8v however drivers/power/axp209.c
> contains an incorrect limit on ldo3 of 2.275v
>
> The origin of the incorrect limit seems likely due to some inconsistencies
> in the axp209 datasheet. ldo3 is described with different limits in
> different sections. register 0x29 uses 7 bits for voltage configuration
> while the 2.275v limit would apply if only 6 bits were used.
> Probably this is a cut&paste error from register 0x23
>
> The linux kernel driver has the correct limit and operation up to the 2.8v
> required by my board has been physically verified with a multimeter.
>
> Signed-off-by: Iain Paton <ipaton0@gmail.com>

Thanks, I've merged this into u-boot-sunxi/master and added this
in a small fixed pull-req which I've just send.

Regards,

Hans

> ---
>   drivers/power/axp209.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/axp209.c b/drivers/power/axp209.c
> index 4565398..f8c9b77 100644
> --- a/drivers/power/axp209.c
> +++ b/drivers/power/axp209.c
> @@ -119,7 +119,7 @@ int axp209_set_ldo3(int mvolt)
>   	if (mvolt == -1)
>   		cfg = 0x80;	/* determined by LDO3IN pin */
>   	else
> -		cfg = axp209_mvolt_to_cfg(mvolt, 700, 2275, 25);
> +		cfg = axp209_mvolt_to_cfg(mvolt, 700, 3500, 25);
>
>   	return axp209_write(AXP209_LDO3_VOLTAGE, cfg);
>   }
>

      reply	other threads:[~2015-03-26 12:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-25 16:03 [U-Boot] [PATCH] sunxi: axp209: fix incorrect limits on ldo3 Iain Paton
2015-03-26 12:26 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5513FB08.1080303@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox