From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: set GMAC TX delay = 0x1 on Cubietruck.
Date: Thu, 26 Mar 2015 13:26:57 +0100 [thread overview]
Message-ID: <5513FB11.2010506@redhat.com> (raw)
In-Reply-To: <1427290745-26578-1-git-send-email-ian.campbell@citrix.com>
Hi,
On 25-03-15 14:39, Ian Campbell wrote:
> Of 4 boards in our automated test system 2 do not have reliable
> networking with the default TX delay of 0x0. Increasing to 0x1 seems
> to make things reliable on all 4 boards.
>
> Some previous ad-hpoc tests with tx delay set to 0, 1, 2 and 3 on one
> of the problematic boards showed:
>
> 0: mw.l 0x1c20164 0x006 1 -- t/o in 4/5 tftp runs
> 1: mw.l 0x1c20164 0x406 1 -- t/o in 1/5 tftp runs
> 2: mw.l 0x1c20164 0x806 1 -- t/o in 1/5 tftp runs
> 3: mw.l 0x1c20164 0xc06 1 -- t/o many times in first tftp run
>
> For 0, 1 and 2 "t/o" means one or two "T" glitches in the download,
> but it did complete. For 3 those were basically continuous and it
> couldn't complete.
>
> tftp was of a 16M initrd.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Thanks, I've merged this into u-boot-sunxi/master and added this
in a small fixed pull-req which I've just send.
Regards,
Hans
> ---
> NB, Unlike the normal typo I actually mean to use my citrix address
> here, since this was done for/at work.
>
> Actual testing was done on v2014.10 with the same direct write hack as
> BananaPi had in that release (but with value == 1), I can't easily
> upgrade the remove machines to something newer. The affect of this
> patch is the same and has been tested on a local board, which didn't
> have problems to start with however.
> ---
> configs/Cubietruck_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configs/Cubietruck_defconfig b/configs/Cubietruck_defconfig
> index 5c23bc7..fa48331 100644
> --- a/configs/Cubietruck_defconfig
> +++ b/configs/Cubietruck_defconfig
> @@ -1,6 +1,7 @@
> CONFIG_SPL=y
> CONFIG_SYS_EXTRA_OPTIONS="AXP209_POWER,SUNXI_GMAC,RGMII,AHCI,SATAPWR=SUNXI_GPH(12),USB_EHCI"
> CONFIG_FDTFILE="sun7i-a20-cubietruck.dtb"
> +CONFIG_GMAC_TX_DELAY=1
> CONFIG_VIDEO_VGA=y
> CONFIG_ARM=y
> CONFIG_ARCH_SUNXI=y
>
prev parent reply other threads:[~2015-03-26 12:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 13:39 [U-Boot] [PATCH] sunxi: set GMAC TX delay = 0x1 on Cubietruck Ian Campbell
2015-03-26 12:26 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5513FB11.2010506@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox