public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] ARM: tegra: update colibri_t20 configuration
Date: Thu, 26 Mar 2015 08:18:56 -0600	[thread overview]
Message-ID: <55141550.3050900@wwwdotorg.org> (raw)
In-Reply-To: <1427332647-13415-1-git-send-email-marcel@ziswiler.com>

On 03/25/2015 07:17 PM, Marcel Ziswiler wrote:
> Bring the Colibri T20 configuration in-line with Apalis/Colibri T30.

I assume all the white-space and line reordering changes are so that a 
diff of colibri_t20.h and colibri_t30.h shows minimal differences?

> diff --git a/include/configs/colibri_t20.h b/include/configs/colibri_t20.h

> +/* General networking support */
>   #define CONFIG_CMD_NET
>   #define CONFIG_CMD_DHCP
> -#define CONFIG_CMD_NFS
> -#define CONFIG_CMD_PING

It might warrant some explanation why those appear to be removed. Are 
they enabled by default anyway?

> +/* Miscellaneous commands */
> +#define CONFIG_CMD_SETEXPR
> +#define CONFIG_FAT_WRITE
> +
> +/* Increase console I/O buffer size */
> +#undef CONFIG_SYS_CBSIZE
> +#define CONFIG_SYS_CBSIZE		1024
> +
> +/* Increase arguments buffer size */
> +#undef CONFIG_SYS_BARGSIZE
> +#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
> +
> +/* Increase print buffer size */
> +#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
> +
> +/* Increase maximum number of arguments */
> +#undef CONFIG_SYS_MAXARGS
> +#define CONFIG_SYS_MAXARGS		32

Is any of that generally useful to other boards; do we want to add those 
lines to tegra*-common*.h instead?

(IIRC some of the command-line size related variables enable the 
ridiculously long kernel command-lines required to boot our downstream 
kernel, so would be useful on at least some other boards. Hence, 
enabling everywhere might be simplest).

  reply	other threads:[~2015-03-26 14:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26  1:17 [U-Boot] [PATCH v2] ARM: tegra: update colibri_t20 configuration Marcel Ziswiler
2015-03-26 14:18 ` Stephen Warren [this message]
2015-03-26 17:33   ` Marcel Ziswiler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55141550.3050900@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox