From: Przemyslaw Marczak <p.marczak@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 2/3] Kconfig: i2c: fix help message related to dm i2c
Date: Tue, 31 Mar 2015 17:57:35 +0200 [thread overview]
Message-ID: <551AC3EF.9040101@samsung.com> (raw)
In-Reply-To: <CAPnjgZ2bkoWcyEJJc8mPYQ50E3RaF+8-BBCf21k+YpyPgRjy2w@mail.gmail.com>
Hello Simon,
On 03/28/2015 04:08 PM, Simon Glass wrote:
> Hi Przemyslaw,
>
> On 27 March 2015 at 11:33, Przemyslaw Marczak <p.marczak@samsung.com> wrote:
>> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
>> Cc: Mike Frysinger <vapier@gentoo.org>
>> Cc: Simon Glass <sjg@chromium.org>
>> Cc: Heiko Schocher <hs@denx.de>
>>
>> Changes V2:
>> - add i2c uclass description
>> ---
>> drivers/i2c/Kconfig | 17 +++++++----------
>> 1 file changed, 7 insertions(+), 10 deletions(-)
>
> Acked-by: Simon Glass <sjg@chromium.org>
>
> (see nit below)
>
>>
>> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
>> index 692810d..979522f 100644
>> --- a/drivers/i2c/Kconfig
>> +++ b/drivers/i2c/Kconfig
>> @@ -2,16 +2,13 @@ config DM_I2C
>> bool "Enable Driver Model for I2C drivers"
>> depends on DM
>> help
>> - Enable driver model for I2C. This SPI flash interface
>> - (spi_flash_probe(), spi_flash_write(), etc.) is then
>> - implemented by the SPI flash uclass. There is one standard
>> - SPI flash driver which knows how to probe most chips
>> - supported by U-Boot. The uclass interface is defined in
>> - include/spi_flash.h, but is currently fully compatible
>> - with the old interface to avoid confusion and duplication
>> - during the transition parent. SPI and SPI flash must be
>> - enabled together (it is not possible to use driver model
>> - for one and not the other).
>> + Enable driver model for I2C. The I2C uclass interface: probe, read,
>> + write or speed, is implemented with the bus drivers uclass operations,
>> + which provides methods for bus setting and data transfer. Each chip
>
> Can we tweak this a bit?
>
> write and speed, is implemented with the bus drivers' operations,
> which provide methods for bus setting and data transfer. Each chip
>
>
Ok, will corrent this.
>> + device (bus child) info is kept as parent platdata. The interface is
>> + defined in include/i2c.h. When i2c bus driver supports the i2c uclass,
>> + but the device drivers not, then DM_I2C_COMPAT config can be used as
>> + compatibility layer.
>>
>> config DM_I2C_COMPAT
>> bool "Enable I2C compatibility layer"
>> --
>> 1.9.1
>>
>
> Regards,
> Simon
>
Best regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
next prev parent reply other threads:[~2015-03-31 15:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 10:30 [U-Boot] [PATCH 0/3] dm: i2c: enable driver model for software i2c Przemyslaw Marczak
2015-03-10 10:30 ` [U-Boot] [PATCH 1/3] dm: i2c soft: enable driver model for software i2c driver Przemyslaw Marczak
2015-03-23 8:44 ` Lukasz Majewski
2015-03-23 23:38 ` Simon Glass
2015-03-24 6:01 ` Heiko Schocher
2015-03-26 13:18 ` Przemyslaw Marczak
2015-03-26 13:18 ` Przemyslaw Marczak
2015-03-10 10:30 ` [U-Boot] [PATCH 2/3] Kconfig: i2c: remove wrong help message related to dm i2c Przemyslaw Marczak
2015-03-23 8:45 ` Lukasz Majewski
2015-03-23 23:39 ` Simon Glass
2015-03-26 13:18 ` Przemyslaw Marczak
2015-03-10 10:30 ` [U-Boot] [PATCH 3/3] Kconfig: i2c: add entry for driver-model software i2c Przemyslaw Marczak
2015-03-23 8:46 ` Lukasz Majewski
2015-03-23 23:40 ` Simon Glass
2015-03-25 3:35 ` Masahiro Yamada
2015-03-26 13:17 ` Przemyslaw Marczak
2015-03-27 17:33 ` [U-Boot] [PATCH V2 0/3] dm: i2c: enable driver model for i2c gpio Przemyslaw Marczak
2015-03-27 17:33 ` [U-Boot] [PATCH V2 1/3] dm: gpio: request list: return the count if requests max_count reached Przemyslaw Marczak
2015-03-28 15:04 ` Simon Glass
2015-03-27 17:33 ` [U-Boot] [PATCH V2 2/3] Kconfig: i2c: fix help message related to dm i2c Przemyslaw Marczak
2015-03-28 15:08 ` Simon Glass
2015-03-31 15:57 ` Przemyslaw Marczak [this message]
2015-03-27 17:33 ` [U-Boot] [PATCH V2 3/3] dm: i2c: add i2c-gpio driver Przemyslaw Marczak
2015-03-28 15:08 ` Simon Glass
2015-03-31 15:58 ` Przemyslaw Marczak
2015-03-31 16:57 ` [U-Boot] [PATCH V3 0/3] dm: i2c: enable driver model for i2c gpio Przemyslaw Marczak
2015-03-31 16:57 ` [U-Boot] [PATCH V3 1/3] dm: gpio: request list: return the count if requests max_count reached Przemyslaw Marczak
2015-04-01 3:17 ` Simon Glass
2015-04-01 3:19 ` Simon Glass
2015-04-01 6:44 ` Przemyslaw Marczak
2015-03-31 16:57 ` [U-Boot] [PATCH V3 2/3] Kconfig: i2c: fix help message related to dm i2c Przemyslaw Marczak
2015-04-01 3:17 ` Simon Glass
2015-04-01 3:19 ` Simon Glass
2015-03-31 16:57 ` [U-Boot] [PATCH V3 3/3] dm: i2c: add i2c-gpio driver Przemyslaw Marczak
2015-04-01 3:18 ` Simon Glass
2015-04-01 3:19 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551AC3EF.9040101@samsung.com \
--to=p.marczak@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox