From mboxrd@z Thu Jan 1 00:00:00 1970 From: Przemyslaw Marczak Date: Fri, 03 Apr 2015 18:08:46 +0200 Subject: [U-Boot] [PATCH v3 11/17] dm: regulator: add max77686 regulator driver In-Reply-To: References: <1425399883-14053-1-git-send-email-p.marczak@samsung.com> <1427229051-20170-1-git-send-email-p.marczak@samsung.com> <1427229051-20170-12-git-send-email-p.marczak@samsung.com> Message-ID: <551EBB0E.1010709@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Simon, On 03/29/2015 03:08 PM, Simon Glass wrote: > Hi Przemyslaw, > > On 24 March 2015 at 14:30, Przemyslaw Marczak wrote: >> This commit adds support to max77686 regulator driver >> based on a uclass regulator driver-model api, which >> provides implementation of all uclass regulator api >> function calls. >> >> New file: drivers/power/regulator/max77686.c >> New config: CONFIG_DM_REGULATOR_MAX77686 >> >> Signed-off-by: Przemyslaw Marczak > > Acked-by: Simon Glass > > See nit below. > >> --- >> Changes V2: >> - change debug() to error() >> - code cleanup >> - fix data types >> - ldo/buck state implementation >> - adjust to new uclass api >> >> Changes V3: >> - regulator/max77686.c: >> -- adjust to api changes >> -- add separeted drivers for buck and ldo >> -- bind regulators by its compatibles >> - Kconfig: add regulator max77686 entry >> --- >> Makefile | 1 + >> drivers/power/Kconfig | 8 + >> drivers/power/Makefile | 1 - >> drivers/power/regulator/Makefile | 8 + >> drivers/power/regulator/max77686.c | 876 +++++++++++++++++++++++++++++++++++++ >> include/power/max77686_pmic.h | 24 +- >> 6 files changed, 914 insertions(+), 4 deletions(-) >> create mode 100644 drivers/power/regulator/Makefile >> create mode 100644 drivers/power/regulator/max77686.c >> >> diff --git a/Makefile b/Makefile >> index 1b3ebe7..9ecf3bb 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -632,6 +632,7 @@ libs-y += drivers/power/ \ >> drivers/power/fuel_gauge/ \ >> drivers/power/mfd/ \ >> drivers/power/pmic/ \ >> + drivers/power/regulator/ \ >> drivers/power/battery/ >> libs-y += drivers/spi/ >> libs-$(CONFIG_FMAN_ENET) += drivers/net/fm/ >> diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig >> index c4d4c72..97abbf0 100644 >> --- a/drivers/power/Kconfig >> +++ b/drivers/power/Kconfig >> @@ -112,6 +112,14 @@ config DM_REGULATOR >> Say y here to enable support for the axp221 / axp223 pmic found on most >> sun6i (A31) / sun8i (A23) boards. >> >> +config DM_REGULATOR_MAX77686 >> + bool "Enable Driver Model for REGULATOR MAX77686" >> + depends on DM_REGULATOR && DM_PMIC_MAX77686 >> + ---help--- >> + This config enables implementation of driver-model regulator uclass >> + features for REGULATOR MAX77686. The driver implements get/set api for: >> + value, enable and mode. > > This should probably go in drivers/power/regulator/Kconfig. > Ok, will fix this. [snip] > > Regards, > Simon > Thanks, -- Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak at samsung.com