From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Mon, 06 Apr 2015 15:40:25 -0600 Subject: [U-Boot] [PATCH v2 3/8] sandbox: Add support for bootz In-Reply-To: <1428354148-1511-4-git-send-email-sjoerd.simons@collabora.co.uk> References: <1428354148-1511-1-git-send-email-sjoerd.simons@collabora.co.uk> <1428354148-1511-4-git-send-email-sjoerd.simons@collabora.co.uk> Message-ID: <5522FD49.1070705@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/06/2015 03:02 PM, Sjoerd Simons wrote: > Add dummy bootz_setup implementation allowing the u-boot sandbox to > run bootz. This recognizes both ARM and x86 zImages to validate a > valid zImage was loaded. > diff --git a/arch/sandbox/lib/bootm.c b/arch/sandbox/lib/bootm.c > +int bootz_setup(ulong image, ulong *start, ulong *end) > + *start = 0xdead; > + *end = 0xbeef; > + return 0; Isn't that going to cause the rest of bootz to access or jump to some bogus address and crash? Aside from that, this series looks plausible, so, Acked-by: Stephen Warren (I read through patch 6 most thoroughly, briefly skimmed patch 7, and read the others fairly quickly, so take that as an ack primarily on patch 6 although I didn't see anything obviously wrong elsewhere).