From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] socfpga: missing DECLARE_GLOBAL_DATA_PTR in timer.c
Date: Wed, 08 Apr 2015 14:43:26 +0200 [thread overview]
Message-ID: <5525226E.9010202@denx.de> (raw)
In-Reply-To: <20150408121238.GA10371@amd>
On 08.04.2015 14:12, Pavel Machek wrote:
>
> for A in `find . -name "*.c"`; do if grep DECLARE_GLOBAL_DATA_PTR $A; then echo -n; else echo $A; fi; done
>
> reveals a few files that probably should have DECLARE_GLOBAL_DATA_PTR.
>
> This fixes it for arch/arm/cpu/armv7/socfpga/timer.c .
>
> Signed-off-by: Pavel Machek <pavel@denx.de>
>
> index 253cde3..2dd8376 100644
> --- a/arch/arm/cpu/armv7/socfpga/timer.c
> +++ b/arch/arm/cpu/armv7/socfpga/timer.c
> @@ -8,6 +8,8 @@
> #include <asm/io.h>
> #include <asm/arch/timer.h>
>
> +DECLARE_GLOBAL_DATA_PTR;
> +
Hmmm, "gd" is not used in this file at all. So not sure if we should add
DECLARE_GLOBAL_DATA_PTR here.
Thanks,
Stefan
prev parent reply other threads:[~2015-04-08 12:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 12:12 [U-Boot] socfpga: missing DECLARE_GLOBAL_DATA_PTR in timer.c Pavel Machek
2015-04-08 12:43 ` Stefan Roese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5525226E.9010202@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox